-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for Order#getAppliedRuleIds #18573
Update documentation for Order#getAppliedRuleIds #18573
Conversation
Update the documentation for getAppliedRuleIds, as it is not immediately clear if this is a single number in a string, or several that are comma separated.
Hi @zack6849. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, you include an empty line before long description, but removed the line after.
Please, include the empty line after long description :-)
Refer: https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zack6849 Thanks for your contribution
Hi @rodrigowebjump, thank you for the review. |
merged |
Hi @zack6849. Thank you for your contribution. |
Description
Update the documentation for getAppliedRuleIds, as it is not immediately clear if this is a single number in a string, or several that are comma separated.
Manual testing scenarios
Contribution checklist