Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Product Tax total on PDF for 2.3, Reference of PL #18649 #19061

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented Nov 4, 2018

Issue of Wee Tax When using FPT, the FPT-total show up at the cart/checkout but is missing at the pdf invoice.

Description (*)

If we enable FPT and add it to the product, after placing order, FTP amount field is displaying on Order view, Invoice view etc, when downloading Invoice Pdf, FTP amount field was missing. In this pull request
i have fixed it.

Fixed Issues (if relevant)

  1. Missing Fixed Product Tax total on PDF #18617
  2. ...

Manual testing scenarios (*)

  1. Enable FPT from Stores > Settings > Configurations > Sales > Tax > Fixed Product Taxes.
  2. Created a new product attribute of type FPT.
  3. Added this attribute to Default attribute set.
  4. Saved product with FTP details.
  5. Placed an order and generated invoice.
  6. Print pdf.

Reference PL of #18649

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @vadimjustus, thank you for the review.
ENGCOM-3393 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants