Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue fixed #20337 Option Title breaking in two line because applying… #20339

Merged
merged 2 commits into from
Mar 1, 2019
Merged

issue fixed #20337 Option Title breaking in two line because applying… #20339

merged 2 commits into from
Mar 1, 2019

Conversation

cedarvinda
Copy link
Member

… wrong css for manage width

issue fixed #20337 Option Title breaking in two line because applying wrong css for manage width

Description (*)

issue fixed #20337 Option Title breaking in two line because applying wrong css for manage width

Manual testing scenarios (*)

  1. Login to admin panel
  2. Go in Catalog > product section
  3. Create new product and go to tab Customizable Options and click on Add option button
    and see first label Option Title (See screenshot shown)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… wrong css for manage width

issue fixed #20337 Option Title breaking in two line because applying wrong css for manage width
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@amol2jcommerce
Copy link
Contributor

Hi @cedarvinda

Not an issue in Magento 2.3.0
2019-01-16_18-28_new product - products

@cedarvinda
Copy link
Member Author

cedarvinda commented Jan 16, 2019

@amol2jcommerce Please check on 1366 x 768 resolution

@VladimirZaets VladimirZaets self-assigned this Jan 16, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3885 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

Hi @cedarvinda. Thanks for collaboration.
The issue is still reproduced with the fix provided in your's PR.

_fields.less updated
@cedarvinda
Copy link
Member Author

@VladimirZaets Now please review.

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 20, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20339.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost
Copy link

ghost commented Mar 1, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment