Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'fixes-for-#20414' :: Recent orders grid not aligned from left in mob… #20429

Merged
merged 1 commit into from
Mar 14, 2019
Merged

'fixes-for-#20414' :: Recent orders grid not aligned from left in mob… #20429

merged 1 commit into from
Mar 14, 2019

Conversation

nainesh2jcommerce
Copy link
Contributor

@nainesh2jcommerce nainesh2jcommerce commented Jan 21, 2019 •
edited by torhoehn
Loading

…ile as all content aligned from left

Description (*)

Fixed Issues (if relevant)

  1. Recent orders grid not aligned from left in mobile as all content aligned from left #20414: Recent orders grid not aligned from left in mobile as all content aligned from left
  2. ...

Manual testing scenarios (*)

  1. Open frontend
  2. Login as customer and go to my account in mobile
  3. see Recent Orders section

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nainesh2jcommerce
Copy link
Contributor Author

Hi @magento-engcom-team,
Any news on this PR? thanks!

@nainesh2jcommerce
Copy link
Contributor Author

Hi @magento-engcom-team,
Any news on this PR?

Thanks!

@nainesh2jcommerce
Copy link
Contributor Author

Hi @magento-engcom-team please review this PR

@nainesh2jcommerce
Copy link
Contributor Author

Hi @magento-engcom-team please review this PR.

@nainesh2jcommerce
Copy link
Contributor Author

@magento-engcom-team any news on this PR?

@torhoehn
Copy link
Contributor

torhoehn commented Feb 5, 2019

@nainesh2jcommerce Your PR will not progressed faster if you ask for it again and again. At the moment there're quite a lot PRs to be reviewed, so please be patient.

@torhoehn torhoehn self-requested a review February 5, 2019 18:42
@torhoehn torhoehn self-assigned this Feb 5, 2019
@torhoehn
Copy link
Contributor

torhoehn commented Feb 6, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, here is your new Magento instance.
Admin access: https://pr-20429.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, thank you for the review.
ENGCOM-4161 has been created to process this Pull Request

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sivaschenko
sivaschenko requested changes Mar 4, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nainesh2jcommerce thanks for the pull request. Can you please recommit the changes for this pull request using the GitHub configuration matching your actual GitHub account (author commit email should match email of GitHub account). Also please make sure to include the static tests fix added to the pull request by @nmalevanec

Once all commits in the pull request are linked to accounts, we'll be able to process the PR further

@nainesh2jcommerce
Copy link
Contributor Author

HI @sivaschenko,

I have commit and push this PR again, can you please review.

Thanks!

@sivaschenko
Copy link
Member

Hi @nainesh2jcommerce , commits still do not link to your account, please make sure you local git email is configured correctly. See https://help.github.com/en/articles/setting-your-commit-email-address-in-git

@nainesh2jcommerce
Copy link
Contributor Author

Hi @sivaschenko,

Thanks for the guidance, I have done again commit and push for this PR, can you please review.

@sivaschenko
Copy link
Member

@nainesh2jcommerce last commit if fine, thanks! However there are still 3 not linked commits. Can you please remove reset the branch a push all using single correct commit

@nainesh2jcommerce
Copy link
Contributor Author

Hi @sivaschenko,

I have made changes as per your request, reset all previous commit and push single commit for this PR, can you please review.

Thanks

@ghost ghost assigned sivaschenko Mar 5, 2019
sivaschenko
sivaschenko approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nainesh2jcommerce

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4161 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 7, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Mar 7, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 14, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit f4d4d9b into magento:2.3-develop Mar 14, 2019
@ghost
Copy link

ghost commented Mar 14, 2019

Hi @nainesh2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 14, 2019
@sidolov
ENGCOM-4161: 'fixes-for-#20414' :: Recent orders grid not aligned fro…
eb3a122 
…m left in mob… #20429
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@torhoehn torhoehn torhoehn approved these changes

Assignees

@torhoehn torhoehn

@sivaschenko sivaschenko

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Area: Design/Frontend Cleanup Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
7 participants
@nainesh2jcommerce @magento-engcom-team @torhoehn @magento-cicd2 @sivaschenko @VasylShvorak @p-bystritsky