Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #20527 [Admin] Configurable product variations table cell labels wrong position #20528

Merged
merged 4 commits into from
Mar 11, 2019
Merged

Fix for #20527 [Admin] Configurable product variations table cell labels wrong position #20528

merged 4 commits into from
Mar 11, 2019

Conversation

vasilii-b
Copy link

Description (*)

Made configurable product variations table body cell label hidden, because they were positioned (absolute) all in on place above the table.
xnip2019-01-23_14-34-51

Fixed Issues (if relevant)

  1. [Admin] Configurable product variations table cell labels wrong position #20527: [Admin] Configurable product variations table cell labels wrong position

Manual testing scenarios (*)

Provided in the issue description.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Made configurable product variations table cell label hidden, because…
af11e87 
… they were positioned (absolute) all in on place above the table
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Design/Frontend Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2019
@vasilii-b vasilii-b requested a review from rogyar January 23, 2019 15:03
@rogyar rogyar mentioned this pull request Jan 24, 2019
Closed
4 tasks
@rogyar
Copy link
Contributor

rogyar commented Jan 24, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3963 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@sivaschenko
Copy link
Member

Hi @vasilii-b , thanks for your contribution! Is it possible to remove the unneeded element instead of hiding it?

@vasilii-b
Copy link
Author

Hi @sivaschenko,
I've changed the way labels are hidden. Can you please take a look ? Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3963 has been created to process this Pull Request

@p-bystritsky
Merge remote-tracking branch 'mainline/2.3-develop' into 2.3-configur…
e8adeca 
…able-product-variations-data-table-labels-alignment
@p-bystritsky p-bystritsky self-assigned this Mar 6, 2019
@ghost ghost added the Progress: accept label Mar 7, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 11, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit e8adeca into magento:2.3-develop Mar 11, 2019
@ghost
Copy link

ghost commented Mar 11, 2019

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 11, 2019
@sivaschenko
ENGCOM-3963: Fix for #20527 [Admin] Configurable product variations t…
fb4a0ad 
…able cell labels wrong position #20528
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 11, 2019
@eduard13 eduard13 mentioned this pull request Mar 11, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@rogyar rogyar

@VladimirZaets VladimirZaets

@p-bystritsky p-bystritsky

Labels
Area: Design/Frontend Award: bug fix Component: ConfigurableProduct Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
7 participants
@vasilii-b @magento-engcom-team @rogyar @sivaschenko @okorshenko @VladimirZaets @p-bystritsky