Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of Lines in a Street Address not setting to default when you checked Use system value in Magento 2.1.7 #13675 #20565

Merged

Conversation

XxXgeoXxX
Copy link
Member

issue #13675

Description (*)

Preconditions

M 2.2.x
M 2.3.x

Steps to reproduce

Login to admin and got to Store->configuration->Customer->Customer Configuration-> Name and Address Options
Set Number of Lines in a Street Address to 3 and save
in front end it display 3 street line
Next click on Use system value and save it
Clear cache
Still its show 3 line for street in address

Expected result

it should display default street no that is two when you unset the value from Use system value

Actual result

it display last saved values instead of default value (i'e 2 )

Manual testing scenarios (*)

Login to admin and got to Store->configuration->Customer->Customer Configuration-> Name and Address Options
Set Number of Lines in a Street Address to 3 and save
in front end it display 3 street line
Next click on Use system value and save it
Clear cache
Still its show 3 line for street in address

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4063 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 10, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: Customer Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants