Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #17564 Magento 2 inline edit date issues in admin grid with Ui Component #20902

Conversation

satyaprakashpatel
Copy link
Contributor

Fixed #17564 Magento 2 inline edit date issues in admin grid with Ui Component
In magento2 Inline Edit date issues while i edit the record it display current date instead of database date

Preconditions

Magento version 2.2.3
php 7.0.29
mysqli mysqlnd 5.0.12

Steps to reproduce

  1. So please make any date filed
    dateRange Magento_Ui/js/grid/columns/date date date Date MMM dd, YYYY
  2. Open edited Grid,

Expected result

When make row inline editable an existing record, the date field should show the date from the record

Actual result

When make row inline editable an existing record, the date field show current date
1

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @satyaprakashpatel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20902.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your Magento instance.
Admin access: https://i-20902-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sivaschenko sivaschenko self-assigned this Feb 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4148 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, here is your Magento instance.
Admin access: https://i-20902-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@VladimirZaets
Copy link
Contributor

Hi @satyaprakashpatel. Thanks for collaboration. I can't reproduce this issue on the fresh Magento 2.3-develop branch. Can you please provide more details?

@satyaprakashpatel
Copy link
Contributor Author

@VladimirZaets for reproducing this error you need to enable inline edit for any date field.
you can see comment of Rutvee123 in main issue
#17564

@VladimirZaets
Copy link
Contributor

@satyaprakashpatel I tried to reproduce it on the content->pages grid. There is already enabled inline editing on the datepicker field

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4148 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 14, 2019

Hi @satyaprakashpatel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants