Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for product tabbing issue #21079

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Fixes for product tabbing issue #21079

merged 3 commits into from
Mar 5, 2019

Conversation

prakash2jcommerce
Copy link

@prakash2jcommerce prakash2jcommerce commented Feb 8, 2019 •
edited by sivaschenko
Loading

Description (*)

  1. On 2.3.0 product detail page 2 tabs are getting active once arrived from product listing page.

Fixed Issues (if relevant)

  1. Tabbing issue on product detail page #21077: Tabbing issue on product detail page

Manual testing scenarios (*)

  1. In Frontend product listing page on list view mode click on Add Your Review link of product it will re-direct on product detail page. Once arrived on product detail page only review tab keep active.

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 8, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ VladimirZaets
❌ Prakash

Prakash seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team
Copy link
Contributor

Hi @prakash2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Feb 8, 2019
VladimirZaets
VladimirZaets reviewed Feb 8, 2019
View reviewed changes
lib/web/mage/tabs.js Outdated
@@ -71,6 +71,9 @@ define([
anchorId = anchor.replace('#', '');

if (anchor && isValid) {
if(anchorId == 'review-form'){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prakash2jcommerce. Thanks for collaboration.
First of all, according to our standarts we should use === instead of ==.

Also, for support flexibility, we should avoid hardcode tab id (review-form)

@VladimirZaets
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, here is your Magento instance.
Admin access: https://i-21079-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@VladimirZaets
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, here is your Magento instance.
Admin access: https://i-21079-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

omiroshnichenko
omiroshnichenko reviewed Feb 12, 2019
View reviewed changes
lib/web/mage/tabs.js Outdated
@@ -71,6 +71,9 @@ define([
anchorId = anchor.replace('#', '');

if (anchor && isValid) {
if(anchorId == 'review-form'){
anchorId = anchorId.replace('-form', 's');
}
$.each(self.contents, function (i) {
if ($(this).attr('id') === anchorId) {
Copy link
Contributor

@omiroshnichenko omiroshnichenko Feb 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prakash2jcommerce, for better fix simply replace if condition in each with:

...
if ($(this).attr('id') === anchorId || $(this).find('#' + anchorId).length) {
...

and remove your fix.

@prakash2jcommerce
Copy link
Author

@omiroshnichenko ,

Yes I have applied fixes in same file please check it further..

@VladimirZaets VladimirZaets mentioned this pull request Feb 13, 2019
Closed
4 tasks
@magento-engcom-team
Copy link
Contributor

@prakash2jcommerce thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@soleksii soleksii self-assigned this Mar 4, 2019
@soleksii
Copy link

soleksii commented Mar 4, 2019

✔️ QA Passed

@nmalevanec nmalevanec self-assigned this Mar 4, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 5, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit c034338 into magento:2.3-develop Mar 5, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

Hi @prakash2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 5, 2019
@sidolov
ENGCOM-4250: Fixes for product tabbing issue #21079
9abbebf
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 5, 2019
@amol2jcommerce amol2jcommerce mentioned this pull request Mar 6, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omiroshnichenko omiroshnichenko omiroshnichenko approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Area: Lib/Frontend Award: bug fix Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
8 participants
@prakash2jcommerce @magento-cicd2 @magento-engcom-team @VladimirZaets @soleksii @omiroshnichenko @sidolov @nmalevanec