Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] [Checkout] Fix clearing admin quote address when removing all items #21785

Merged
merged 1 commit into from
Mar 20, 2019
Merged

[Forwardport] [Checkout] Fix clearing admin quote address when removing all items #21785

merged 1 commit into from
Mar 20, 2019

Conversation

eduard13
Copy link
Contributor

Related PR #21051

Description (*)

After filling in a backend Magento Admin new order and then removing all items from the order creation screen, when you then add an item back in you cannot select any shipping rates and "Sorry, no quotes are available" appears until you modify the address to cause it to re-save the address.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. Login to Magento Admin and go to Sales, Orders and click Create New Order
  2. Click Create New Customer
  3. Enter a product into the order and complete the email and address fields, unticking shipping same as billing and filling in another address in the shipping address
  4. Shipping methods will be visible
  5. Now empty the product list and then add another product back in
  6. Click get shipping in the shipping area, if there is a link to do so
  7. Note it says Sorry, no quotes available even though the address is filled in above
  8. Modify address such as telephone number and retry - the shipping methods now appear

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from dmytro-ch March 16, 2019 08:44
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Checkout Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 16, 2019
@dmytro-ch dmytro-ch self-assigned this Mar 16, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21785.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch changed the title [Checkout] Fix clearing admin quote address when removing all items [Forwardport] [Checkout] Fix clearing admin quote address when removing all items Mar 16, 2019
@dmytro-ch dmytro-ch added the Port label Mar 16, 2019
@ghost ghost assigned sivaschenko Mar 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4510 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4510 has been created to process this Pull Request

@soleksii soleksii self-assigned this Mar 18, 2019
@soleksii soleksii mentioned this pull request Mar 18, 2019
Merged
4 tasks
@soleksii
Copy link

✔️ QA Passed

@p-bystritsky p-bystritsky self-assigned this Mar 18, 2019
@ghost ghost added the Progress: accept label Mar 18, 2019
@magento-engcom-team magento-engcom-team merged commit 01eb7e6 into magento:2.3-develop Mar 20, 2019
@ghost
Copy link

ghost commented Mar 20, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 20, 2019
@sidolov
ENGCOM-4510: [Forwardport] [Checkout] Fix clearing admin quote addres…
ed47c5d 
…s when removing all items #21785
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@dmytro-ch dmytro-ch

@p-bystritsky p-bystritsky

@soleksii soleksii

Labels
Component: Checkout Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@eduard13 @magento-engcom-team @dmytro-ch @soleksii @sivaschenko @p-bystritsky