Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Disable dropdown in JavaScript and CSS Settings in developer configur… #21800

Merged
merged 1 commit into from
Mar 20, 2019
Merged

[Backport] Disable dropdown in JavaScript and CSS Settings in developer configur… #21800

merged 1 commit into from
Mar 20, 2019

Conversation

ananth-iyer
Copy link
Member

Original Pull Request

#21444

Description (*)

Fixed Issues (if relevant)

  1. JS minify field is not disabled in developer configuration #21384: JS minify field is not disabled in developer configuration
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ananth-iyer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ananth-iyer ananth-iyer changed the title Disable dropdown in JavaScript and CSS Settings in developer configur… [Backport] Disable dropdown in JavaScript and CSS Settings in developer configur… Mar 16, 2019
@dmytro-ch dmytro-ch self-requested a review March 17, 2019 09:02
@dmytro-ch dmytro-ch self-assigned this Mar 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4517 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 19, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Mar 19, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 20, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 095b9f4 into magento:2.2-develop Mar 20, 2019
@ghost
Copy link

ghost commented Mar 20, 2019

Hi @ananth-iyer, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 20, 2019
@sidolov
ENGCOM-4517: [Backport] Disable dropdown in JavaScript and CSS Settin…
0f76e4c 
…gs in developer configur… #21800
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Component: Backend Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
6 participants
@ananth-iyer @magento-engcom-team @VasylShvorak @DanielRuf @dmytro-ch @p-bystritsky