Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to show filter text in URL rewrite grid after click on back button #21834

Merged

Conversation

vbmagento
Copy link
Contributor

@vbmagento vbmagento commented Mar 19, 2019

Description (*)

Changes are related to URL grid issue (i.e. https://github.com/magento/magento2/issues/21805)
Argument i.e. "save_parameters_in_session" is not available in below xml file.
XML file: adminhtml_logging_block.xml

Fixed Issues (if relevant)

  1. Filter in url rewrites table in backend isn't being remembered #21805: Filter in url rewrites table in backend isn't being remembered

Manual testing scenarios (*)

In Magento backend, go to Marketing > URL Rewrites
Put a filter in one of the columns (like in the Request Path column) and apply it
Click on one of the filtered results
Click on the Back button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 19, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @vbmagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@vbmagento vbmagento changed the title Add argument to show filter text in URL rewrite grid after click on b… Add argument to show filter text in URL rewrite grid after click on back button Mar 20, 2019
@vbmagento
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @vbmagento. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @vbmagento, here is your new Magento instance.
Admin access: https://pr-21834.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@vbmagento
Copy link
Contributor Author

Thanks for test instance.
I have verified changes on test instance. It is working as expected.
Now filter is not removing, which we enter in url rewrite grid.

@hostep
Copy link
Contributor

hostep commented Mar 20, 2019

Nice one @vbmagento, I can confirm your fix works on the test instance!

Can you update your PR so it follows Magento code standards? I noticed you used tabs to indent the xml, but Magento uses spaces, so if you could change the tabs into spaces, the PR will get accepted faster I believe :)

Used spaces instead of tabs
@hostep
Copy link
Contributor

hostep commented Mar 20, 2019

@vbmagento: I see you've updated the PR, but you are still using tabs (just fewer tabs then before). Can you make sure your editor isn't accidentally converting spaces into tabs when you save the file? Maybe that is what causes it.

@vbmagento
Copy link
Contributor Author

@vbmagento: I see you've updated the PR, but you are still using tabs (just fewer tabs then before). Can you make sure your editor isn't accidentally converting spaces into tabs when you save the file? Maybe that is what causes it.

@hostep: I have updated it with space now.

@hostep
Copy link
Contributor

hostep commented Mar 20, 2019

Looks good, thanks! :)

@ghost ghost assigned ihor-sviziev Mar 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4586 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@vbmagento thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@soleksii
Copy link

✔️ QA Passed

Result:

after

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2019

Hi @vbmagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants