-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument to show filter text in URL rewrite grid after click on back button #21834
Add argument to show filter text in URL rewrite grid after click on back button #21834
Conversation
Hi @vbmagento. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @vbmagento. Thank you for your request. I'm working on Magento instance for you |
Hi @vbmagento, here is your new Magento instance. |
Thanks for test instance. |
Nice one @vbmagento, I can confirm your fix works on the test instance! Can you update your PR so it follows Magento code standards? I noticed you used tabs to indent the xml, but Magento uses spaces, so if you could change the tabs into spaces, the PR will get accepted faster I believe :) |
Used spaces instead of tabs
@vbmagento: I see you've updated the PR, but you are still using tabs (just fewer tabs then before). Can you make sure your editor isn't accidentally converting spaces into tabs when you save the file? Maybe that is what causes it. |
@hostep: I have updated it with space now. |
Looks good, thanks! :) |
Hi @ihor-sviziev, thank you for the review. |
@vbmagento thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hi @vbmagento, thank you for your contribution! |
…er click on back button #21834
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)