Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Adjusting the Magento_Ui typos #21940

Merged
merged 1 commit into from
Apr 5, 2019
Merged

[UI] Adjusting the Magento_Ui typos #21940

merged 1 commit into from
Apr 5, 2019

Conversation

eduard13
Copy link
Contributor

Description (*)

This PR fixes some typos in several JS files from Magento_Ui module.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from dmytro-ch March 26, 2019 15:14
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Ui Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 26, 2019
@dmytro-ch dmytro-ch self-assigned this Mar 26, 2019
@ghost ghost assigned sidolov Mar 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4590 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4590 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 29, 2019
@VasylShvorak
Copy link
Contributor

Notice: QA not applicable

@p-bystritsky p-bystritsky self-assigned this Apr 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 1d91d51 into magento:2.3-develop Apr 5, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 5, 2019
@sidolov
ENGCOM-4590: [UI] Adjusting the Magento_Ui typos #21940
22cb00a
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

@dmytro-ch dmytro-ch

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Area: Frontend Cleanup Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@eduard13 @magento-engcom-team @VasylShvorak @sidolov @dmytro-ch @p-bystritsky