Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shipping method block alignment issue #21963

Merged
merged 3 commits into from
Apr 28, 2019

Conversation

vishal-7037
Copy link
Contributor

Description (*)

Fixed shipping method block alignment issue at sales order page

Fixed Issues (if relevant)

  1. Magento Sales Order: Design Align issue #21962: Magento Sales Order: Design Align issue

Manual testing scenarios (*)

  1. Login to admin
  2. Go to Sales > Order, Open any order.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 27, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @vishal-7037. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4594 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky
Copy link
Contributor

@vishal-7037
We can not accept this PR as it brokes page layout and makes "Get shipping methods and rates" hyperlink unclickable.
Peek 2019-04-03 15-04

@vishal-7037
Copy link
Contributor Author

Hi @dmytro-ch,
I've updated the requested changes.

@p-bystritsky
Copy link
Contributor

@vishal-7037 we still have multiple functional test failures:

MAGETWO-94470: Checking availability of 'Credit memo' button for order with no payment required
[NO TESTCASEID]: Create Order in Admin and update bundle product configuration
[NO TESTCASEID]: Fields validation is required to create an order from Admin Panel
MAGETWO-61001: Free Shipping is not available in Admin if Minimum Order Amount does not match
MAGETWO-92925: Admin order is not restricted by 'Minimum Order Amount' configuration.
MAGETWO-92980: Email is required to create an order from Admin Panel
MAGETWO-93677: Create order using Braintree payment
MAGETWO-94472: Admin should be able to open a New Credit Memo Page from Invoice Page for Order with tax and discount and payed using online payment method
MAGETWO-95175: Checking Credit memo Totals
MC-6029: UI validation for Payment methods when creating an order from admin

@vishal-7037
Copy link
Contributor Author

Hi @p-bystritsky,
Thanks for quick reply. I've made changes regarding the design issue.
I don't think so above listed functional test failure because of these changes.

Can you please verify once?

Thanks.

@p-bystritsky
Copy link
Contributor

@vishal-7037, I've fixed functional tests.

@vishal-7037
Copy link
Contributor Author

Hi @p-bystritsky,
Okay. I've got it.
Thank you.

@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2019

Hi @vishal-7037, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants