Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in README.md #22135

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix broken link in README.md #22135

merged 1 commit into from
Apr 11, 2019

Conversation

samuel27m
Copy link
Contributor

@samuel27m samuel27m commented Apr 3, 2019

Description (*)

Fixed broken link in README.md

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Click the link "Magento System Requirements" link in README.md
  2. It works

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2019

Hi @samuel27m. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4661 has been created to process this Pull Request

Copy link
Contributor

@mikeshatch mikeshatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye, samuel. There's also another broken link where it says "Bugcrowd researcher crowd." I tried to fix it myself, but it wouldn't allow me to.

@samuel27m
Copy link
Contributor Author

@mikeshatch Do you know the specific URL? Maybe you could create a PR yourself to fix that one. There's also another one https://magento.com/security/reporting-magento-security-issue that just redirects to the same broken link you mentioned

@mikeshatch
Copy link
Contributor

@samuel27m I haven't been able to do a Pull Request since Magento invited me to be a part of their organization. I haven't been able to figure it out yet. That's why I suggested it to you in case you were interested.

@soleksii
Copy link

soleksii commented Apr 9, 2019

✔️ QA Passed

@mautz-et-tong
Copy link
Contributor

mautz-et-tong commented Apr 9, 2019

@mikeshatch: The Bugcrowd link is already fixed here: #22195

@mikeshatch
Copy link
Contributor

@mikeshatch: The Bugcrowd link is already fixed here: #22195

It was fixed before I noticed it, you mean? I still see this link as broken: https://bugcrowd.com/magento

@mautz-et-tong
Copy link
Contributor

Bugcrowd was replaced with hackerone. That is why there is this PR: https://github.com/magento/magento2/pull/22195/files. So there is no need to take care on the broken link as it will be replaced.

@mikeshatch
Copy link
Contributor

Bugcrowd was replaced with hackerone. That is why there is this PR:

I see. Thank you!

@nmalevanec nmalevanec self-assigned this Apr 10, 2019
@magento-engcom-team magento-engcom-team merged commit 4ce2497 into magento:2.3-develop Apr 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @samuel27m, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants