Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed] Full Tax Summary missing calculation Admin create order #22233

Conversation

niravkrish
Copy link
Contributor

Preconditions:

  1. Magento 2.3.x
  2. Mangento 2.2.x

Description (*)

The full tax summary is displaying total tax, instead of showing individual tax value.

Fixed Issues (if relevant)

Steps to reproduce:

  1. Set Display Full Tax Summary to Yes From Store Configuration > Sales > Tax
  2. Set up 2 tax rule to apply 2 taxes.
  3. Create an order with 2 taxes from magento 2 admin.
  4. Scroll Down to Total and Subtotal Check and expand TAX. Tax summary display tax total not display sepereate tax calulated amount.

Manual testing scenarios (*)

  1. Manual Testing

Expected result

Tax should have a different value calculated by tax percentage.

expected

Actual Result

Tax have a totaled value instead of separate calculated Value.

actual

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2019

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-4737 has been created to process this Pull Request

@ronak2ram ronak2ram removed their request for review April 11, 2019 08:53
@VasylShvorak VasylShvorak self-assigned this Apr 16, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants