Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue of drop-down arrow direction in cart price rule #22456

Merged

Conversation

hiren0241
Copy link
Contributor

Description (*)

Fixed issue of drop-down arrow direction in cart price rule.

Fixed Issues (if relevant)

  1. While add cart price rule from admin click on Condition drop-down arrow direction not change. #22434: While add cart price rule from admin click on Condition drop-down arrow direction not change.

Manual testing scenarios (*)

  1. Go to Admin
  2. Marketing > Cart Price rule
  3. Conditions > Click on +
  4. Open/close and review the Drop-down arrow direction
  5. Drop down arrow should be changes as per other drop-downs

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2019

Hi @hiren0241. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@hiren0241
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your new Magento instance.
Admin access: https://pr-22456.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ronak2ram ronak2ram self-requested a review April 22, 2019 13:32
@ronak2ram ronak2ram self-assigned this Apr 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-4797 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2019

Hi @hiren0241, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12
Copy link
Contributor

meker12 commented Jun 3, 2019

Release note:

UI
In the Conditions section of the New Cart Price Rule page in the Magento Admin, the dropdown arrow in the _If ALL of these conditions are TRUE _ field now points in the correct direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants