Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field. #22697

Closed
wants to merge 2 commits into from
Closed

Conversation

GovindaSharma
Copy link
Contributor

fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field.

Description (*)

fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field.

Fixed Issues (if relevant)

fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field.

  1. V1/carts/mine/billing-address returning %fieldName is a required field. #7299: fixed issue V1/carts/mine/billing-address returning %fieldName is a required field. #7299 V1/carts/mine/billing-address returning %fieldName is a required field.

Manual testing scenarios (*)

Preconditions

Magento EE 2.1.1
PHP 7.0.12
Mysql Ver 14.14 Distrib 5.6.33-79.0, for Linux (x86_64) using 6.2

Steps to reproduce

Go to the checkout after adding something to the basket
Send a request to the REST endpoint V1/carts/mine/billing-address using the payload below

{"cartId":"190488","address":{"countryId":"GB","regionId":"0","region":"","street":["54 Carnegie Court",""],"company":"","telephone":"0165 4569 8754","fax":"","postcode":"AB1C 2DF","city":"SomeCity","firstname":"Bob","lastname":"White","save_in_address_book":1,"saveInAddressBook":null}}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Govind Sharma added 2 commits May 4, 2019 15:51
fixed param issue
change int to string
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gakonhd
Copy link

gakonhd commented May 13, 2019

@magento-engcom-team hello, is there any progress on this issue yet ?

@sdzhepa
Copy link
Contributor

sdzhepa commented May 23, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-22697.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@slavvka slavvka self-assigned this Aug 6, 2019
@slavvka
Copy link
Member

slavvka commented Aug 6, 2019

@magento run all tests

@slavvka
Copy link
Member

slavvka commented Aug 7, 2019

Hey @GovindaSharma please fix the failing tests - Functional and WebAPI. YOu can ignore Database Compare. Also we need to have all fixes covered with automated tests. WebAPI is appropriate here

@slavvka
Copy link
Member

slavvka commented Aug 8, 2019

@magento run Database Compare build

@@ -15,7 +15,7 @@ interface BillingAddressManagementInterface
/**
* Assigns a specified billing address to a specified cart.
*
* @param int $cartId The cart ID.
* @param string $cartId The cart ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cart id should be int instead of string.

@ghost ghost assigned sidolov Aug 13, 2019
@sidolov
Copy link
Contributor

sidolov commented Aug 21, 2019

@GovindaSharma , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 21, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants