Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Credit memo submit button(refund) stays disable after validation fails & unable to enable button issue. #23286

Conversation

nishantjariwala
Copy link
Member

Description (*)

Hi,
Here I've fixed issue for refund button stays disable issue after updating value.

Fixed Issues (if relevant)

  1. Credit memo submit button(refund) stays disable after validation fails & unable to enable button #23285: Credit memo submit button(refund) stays disable after validation fails & unable to enable button

Manual testing scenarios (*)

  1. From the Sales order click on credit memo.
  2. Credit memo window will be opened.
  3. Go to Refund Shipping in Refund Totals section. Here, enter a negative value and click on refund button.
  4. https://prnt.sc/o2vqsu
  5. Now, After correcting the value.
  6. https://prnt.sc/o2vuft

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2019

Hi @nishantjariwala. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned sidolov Jun 19, 2019
@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jun 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5325 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@nishantjariwala thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2019

Hi @nishantjariwala, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Jun 21, 2019
…ter validation fails & unable to enable button issue. magento#23286
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants