Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #24922 "Create Permanent Redirect for URLs if URL Key Changed" for categories #24931

Closed
wants to merge 5 commits into from

Conversation

gaurav-473
Copy link
Contributor

Fixed issue #24922
When setting the config option Stores > Configuration > Catalog > Catalog > SEO > Create Permanent Redirect for URLs if URL Key Changed to "No". The "Create Permanent Redirect for old URL" is unchecked by default for products but is still checked by default when you change the URL key on a category.

Preconditions (*)

  1. Magento 2.3.2

Steps to reproduce (*)

  1. Go to Stores > Configuration > Catalog > Catalog > Search Engine Optimisation and set Create Permanent Redirect for URLs if URL Key Changed to "No".
  2. Go to any category and edit the URL key.

Expected result (*)

  1. "Create Permanent Redirect for old URL" is unchecked by default (like products)

Actual result (*)

  1. "Create Permanent Redirect for old URL" is **checked ** by default

screenshot-magento staging edge-servers com-2019 10 08-12_41_44

screenshot-magento staging edge-servers com-2019 10 08-12_42_37

@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @gauravagarwal1001. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@gaurav-473
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001, here is your new Magento instance.
Admin access: https://pr-24931.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@kalpmehta kalpmehta self-assigned this Oct 8, 2019
@kalpmehta
Copy link
Contributor

@gauravagarwal1001 Please cover your changes with automated tests.

@gaurav-473
Copy link
Contributor Author

@gauravagarwal1001 Please cover your changes with automated tests.

ok

@gaurav-473 gaurav-473 requested review from shikhamis11 and removed request for shikhamis11 October 11, 2019 18:09
@gaurav-473 gaurav-473 closed this Oct 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 14, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@shikhamis11 shikhamis11 reopened this Oct 14, 2019
@ghost ghost unassigned kalpmehta Oct 14, 2019
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:19
@lenaorobei
Copy link
Contributor

Closing this PR due to inactivity. Please feel free to reopen if you are up to finishing it.

@lenaorobei lenaorobei closed this Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants