Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url #30410

GovindaSharma · 2020-10-10T08:55:39Z

Preconditions (*)

Magento 2.4 Develop

Description (*)

Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url

Fixes #30424

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/417

Manual testing scenarios (*)

1.Create An Order In Magento

2.Create invoice, shipment and creditmemo of that Order

3.View the created shipment,invoice and creditmemo

4.Now change the shipment id ,invoiceid and creditmemo id from url(use that id which does not exist) and run the url.

Expected result (*)

A proper error message should come

Actual Result (*)

error page occurs

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url #30424: Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url

…id in url of view page.

m2-assistant · 2020-10-10T08:55:41Z

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

GovindaSharma · 2020-10-10T08:59:03Z

#dmcdindia2020

sivaschenko · 2020-10-10T10:36:09Z

@magento create issue

gabrieldagama · 2020-10-10T11:23:17Z

@magento run all tests

GovindaSharma · 2020-10-10T11:39:58Z

@magento give me test instance

magento-deployment-service · 2020-10-10T11:40:01Z

Hi @GovindaSharma. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-10T11:44:41Z

Hi @GovindaSharma, here is your Magento Instance: https://c0f4193f0636baaeb8cd2e25ecf8c4df.instances.magento-community.engineering
Admin access: https://c0f4193f0636baaeb8cd2e25ecf8c4df.instances.magento-community.engineering/admin_528d
Login: ee57d18c
Password: 9b847b47f6b2

rogyar

Hi @GovindaSharma. Thank you for your contribution. Great Job!
Please, check my comments below. Please note, my recommendations are also applicable for all three entities (I've left the comments for credit memo only)

rogyar · 2020-10-10T12:56:15Z

app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminGoToCreditmemoViewActionGroup.xml

+        <amOnPage url="{{AdminCreditmemoViewPage.url}}/{{identifier}}" stepKey="amOnCreditmemoViewPage"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
+    </actionGroup>
+</actionGroups>


Please, add a new line at the end of the file

rogyar · 2020-10-10T12:56:26Z

app/code/Magento/Sales/Test/Mftf/Test/AdminOpenCreditmemoViewPageWithWrongCreditmemoIdTest.xml

+        <see selector="{{AdminMessagesSection.error}}" userInput='This creditmemo no longer exists.'
+             stepKey="seeErrorMessage"/>
+    </test>
+</tests>


Please, add a new line at the end of the file

rogyar · 2020-10-10T12:57:57Z

app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminGoToCreditmemoViewActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminGoToCreditmemoViewActionGroup">


I would suggest renaming this action group to something like AdminOpenCreditMemoByEntityIdActionGroup. Just to use more or less the same naming as, for example, in the following implementation

magento2/app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminOpenOrderByEntityIdActionGroup.xml

Line 11 in ae280ac

<actionGroup name="AdminOpenOrderByEntityIdActionGroup">

Hi @rogyar .Thaks for your review. But can you please let me know what is the need of renaming the action group name? i have used this name based on other action group name.

This one is not critical, but you may find the example of another action group in the Sales module in my previous comment. My recommendation is more about keeping the names transparent, i.e.

AdminOpenCreditMemoByEntityIdActionGroup (new)

AdminOpenOrderByEntityIdActionGroup (existing)

rogyar · 2020-10-10T13:00:32Z

app/code/Magento/Sales/Test/Mftf/Test/AdminOpenCreditmemoViewPageWithWrongCreditmemoIdTest.xml

+
+        <seeInCurrentUrl url="{{AdminCreditmemosGridPage.url}}" stepKey="redirectToCreditmemosGridPage"/>
+
+        <see selector="{{AdminMessagesSection.error}}" userInput='This creditmemo no longer exists.'


Please, use the following action group instead

magento2/app/code/Magento/Backend/Test/Mftf/ActionGroup/AssertMessageInAdminPanelActionGroup.xml

Line 11 in 83e3487

<actionGroup name="AssertMessageInAdminPanelActionGroup">

Hi @rogyar what is the need of changing action group name for this file as it belongs to Magento_Backend module, i have done commits on Sales and Shipping module.

The main reason is following the best practices and building the test body using action groups only. If we already have an action group for some purpose it's recommended to use it rather than introduce a new check.

rogyar · 2020-10-10T13:01:38Z

app/code/Magento/Sales/Test/Mftf/Test/AdminOpenCreditmemoViewPageWithWrongCreditmemoIdTest.xml

+
+        <waitForPageLoad stepKey="waitForPageLoad"/>
+
+        <seeInCurrentUrl url="{{AdminCreditmemosGridPage.url}}" stepKey="redirectToCreditmemosGridPage"/>


I would suggest using the following action group instead if possible

magento2/app/code/Magento/Backend/Test/Mftf/ActionGroup/AdminAssertPageTitleActionGroup.xml

Line 11 in 83e3487

<actionGroup name="AdminAssertPageTitleActionGroup">

engcom-Charlie · 2020-12-01T14:57:31Z

@magento run all tests

…e id ,creditmemo id passed in url #30410

m2-assistant · 2020-12-23T05:06:53Z

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

GovindaSharma · 2021-01-19T06:56:41Z

@magento give me 2.4-develop instance

magento-deployment-service · 2021-01-19T06:56:43Z

Hi @GovindaSharma. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-01-19T07:02:11Z

Hi @GovindaSharma, here is your Magento Instance: https://c0f4193f0636baaeb8cd2e25ecf8c4df-2-4-develop.instances.magento-community.engineering
Admin access: https://c0f4193f0636baaeb8cd2e25ecf8c4df-2-4-develop.instances.magento-community.engineering/admin_deea
Login: 77a3a514
Password: d1606155c66e

govindasharma974 added 2 commits October 10, 2020 14:11

Fixed issue related with wrong invoice id ,creditmemo id and shipmen …

ff1a003

…id in url of view page.

Fixed issue related with wrong invoice id ,creditmemo id and shipmen …

0e78fe4

…id in url of view page.

ghost added the Progress: pending review label Oct 10, 2020

magento-engcom-team added Component: Sales Component: Shipping Release Line: 2.4 Partner: Cedcommerce partners-contribution Pull Request is created by Magento Partner labels Oct 10, 2020

GovindaSharma changed the title ~~Dcmm2020~~ Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url Oct 10, 2020

magento-engcom-team added the Event: dmcdindia2020 label Oct 10, 2020

m2-assistant bot mentioned this pull request Oct 10, 2020

[Issue] Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url #30424

Closed

4 tasks

sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 10, 2020

Govind Sharma and others added 2 commits October 10, 2020 16:27

Update ViewTest.php

ff5de32

Merge branch '2.4-develop' into dcmm2020

1dab430

rogyar self-assigned this Oct 10, 2020

rogyar requested changes Oct 10, 2020

View reviewed changes

rogyar added the Award: test coverage label Oct 10, 2020

ghost added Progress: needs update and removed Progress: pending review labels Oct 10, 2020

rogyar removed the Progress: needs update label Oct 10, 2020

m2-community-project bot added the Progress: testing in progress label Nov 30, 2020

update severity, testCaseId

ffc0ab7

engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Dec 1, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Dec 1, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 1, 2020

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Dec 1, 2020

engcom-Charlie added 2 commits December 1, 2020 10:18

update severity, testCaseId

247817a

Merge branch '2.4-develop' into dcmm2020

5ec7bd4

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Dec 3, 2020

gabrieldagama removed the request for review from rogyar December 10, 2020 12:58

Merge branch '2.4-develop' into dcmm2020

52b5270

magento-engcom-team pushed a commit that referenced this pull request Dec 23, 2020

ENGCOM-8498: Fatal error page occurs if use wrong shipment id ,invoic…

c2a38cd

…e id ,creditmemo id passed in url #30410

magento-engcom-team merged commit d7f15e9 into magento:2.4-develop Dec 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url #30410

Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url #30410

GovindaSharma commented Oct 10, 2020 •

edited by engcom-Charlie

Loading

m2-assistant bot commented Oct 10, 2020

GovindaSharma commented Oct 10, 2020

sivaschenko commented Oct 10, 2020

gabrieldagama commented Oct 10, 2020

GovindaSharma commented Oct 10, 2020

magento-deployment-service bot commented Oct 10, 2020

magento-deployment-service bot commented Oct 10, 2020

rogyar left a comment

rogyar Oct 10, 2020

rogyar Oct 10, 2020

rogyar Oct 10, 2020

GovindaSharma Oct 12, 2020

rogyar Oct 17, 2020

rogyar Oct 10, 2020

GovindaSharma Oct 12, 2020

rogyar Oct 17, 2020

rogyar Oct 10, 2020

engcom-Charlie commented Dec 1, 2020

m2-assistant bot commented Dec 23, 2020

GovindaSharma commented Jan 19, 2021

magento-deployment-service bot commented Jan 19, 2021

magento-deployment-service bot commented Jan 19, 2021


		<seeInCurrentUrl url="{{AdminCreditmemosGridPage.url}}" stepKey="redirectToCreditmemosGridPage"/>

		<see selector="{{AdminMessagesSection.error}}" userInput='This creditmemo no longer exists.'


		<waitForPageLoad stepKey="waitForPageLoad"/>

		<seeInCurrentUrl url="{{AdminCreditmemosGridPage.url}}" stepKey="redirectToCreditmemosGridPage"/>

Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url #30410

Fatal error page occurs if use wrong shipment id ,invoice id ,creditmemo id passed in url #30410

Conversation

GovindaSharma commented Oct 10, 2020 • edited by engcom-Charlie Loading

Preconditions (*)

Description (*)

Related Pull Requests

Manual testing scenarios (*)

Expected result (*)

Actual Result (*)

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Oct 10, 2020

GovindaSharma commented Oct 10, 2020

sivaschenko commented Oct 10, 2020

gabrieldagama commented Oct 10, 2020

GovindaSharma commented Oct 10, 2020

magento-deployment-service bot commented Oct 10, 2020

magento-deployment-service bot commented Oct 10, 2020

rogyar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

engcom-Charlie commented Dec 1, 2020

m2-assistant bot commented Dec 23, 2020

GovindaSharma commented Jan 19, 2021

magento-deployment-service bot commented Jan 19, 2021

magento-deployment-service bot commented Jan 19, 2021

GovindaSharma commented Oct 10, 2020 •

edited by engcom-Charlie

Loading