Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFTF] Refactoring of AdminMassOrdersCancelCompleteAndClosedTest #31123

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Dec 2, 2020

Description (*)

A new test has been created according to the best practices followed by MFTF.
The old "AdminMassOrdersCancelCompleteAndClosedTest" has been deprecated.

Manual testing scenarios (*)

  1. Create two orders
  2. Invoice and ship the first order
  3. Invoice and refund the second order
  4. Go to the Orders Grid
  5. Try to cancel both orders via mass update
  6. Verify the result

Resolved issues:

  1. resolves [Issue] [MFTF] Refactoring of AdminMassOrdersCancelCompleteAndClosedTest #31129: [MFTF] Refactoring of AdminMassOrdersCancelCompleteAndClosedTest

@m2-assistant
Copy link

m2-assistant bot commented Dec 2, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 2, 2020
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Dec 2, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak AnnaAPak changed the title Refactoring of AdminMassOrdersCancelCompleteAndClosedTest [MFTF] Refactoring of AdminMassOrdersCancelCompleteAndClosedTest Dec 2, 2020
@rogyar rogyar self-assigned this Dec 2, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak. Awesome piece of work!
Please, check my suggestion regarding the naming.


<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
<test name="AdminMassOrdersCancelCompleteAndClosedAPITest">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing the API keyword from the test name. Despite the fact we create entities via API, we test the admin UI behavior eventually (not the API). For API we have a different type of tests.

Suggested change
<test name="AdminMassOrdersCancelCompleteAndClosedAPITest">
<test name="AdminMassOrdersCancelCompleteAndClosedAPITest">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogyar, I have renamed the test. Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8538 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Dec 22, 2020

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Refactoring of AdminMassOrdersCancelCompleteAndClosedTest
6 participants