MC-30152: Bundle Product / Create / Price validation for dynamic price #31501

engcom-Echo · 2021-01-04T08:21:18Z

Description (*)

Disappear error message after disabled field.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Bundle Product / Create / Price validation for dynamic price #26214

Manual testing scenarios (*)

See: #26214

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-01-04T08:21:20Z

Hi @engcom-Echo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Echo · 2021-01-04T08:22:58Z

@magento run all tests

engcom-Echo · 2021-01-04T20:26:35Z

@magento run all tests

eduard13 · 2021-01-05T08:52:39Z

@magento run WebAPI Tests

eduard13

Hi @engcom-Echo, thank you for the fix and test coverage. Could you please review the minor suggestions from my side?

eduard13 · 2021-01-05T09:23:46Z

...agento/Ui/Test/Mftf/ActionGroup/AssertAdminErrorMessageDisappearDisabledFieldActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertAdminErrorMessageDisappearDisabledFieldActionGroup">


The ActionGroup does too many things and I don't think it's a reusable one. I would split it in at least into the following ones:

AdminTogglePriceSwitcherActionGroup

AdminFocusAndFillElementActionGroup

AdminAssertErrorIsVisibleActionGroup / AdminAssertErrorIsNotVisibleActionGroup

What do you think about a such refactoring?
Thank you.

Thanks. Good idea.

eduard13 · 2021-01-05T09:26:44Z

app/code/Magento/Ui/Test/Mftf/Test/AdminDisappearErrorValidateMessageFieldTest.xml

+-->
+<!-- Test XML Example -->
+<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
+    <test name="AdminDisappearErrorValidateMessageFieldTest">


I would rather move this test under Magento_Bundle module, as the test is more related to Bundle product. What do you think?

Hi, @eduard13
We change UI component and I think a test must be in module Ui. The test scenario is related to an issue. Maybe there are other places where the issue is reproduced but I didn't find them.

Generally, a non written rule says that we shouldn't be using ActionGroups/Entities, etc. for modules that we don't have in dependencies. But seeing that Ui > Sales > Bundle, most likely we should be fine here.

eduard13 · 2021-01-05T09:36:37Z

app/code/Magento/Ui/Test/Mftf/Test/AdminDisappearErrorValidateMessageFieldTest.xml

+            <features value="Ui component"/>
+            <stories value="Error message"/>
+            <title value="Assert disappear error message."/>
+            <description value="Verify disappear error message when disabled field."/>


If moving it to Bundle module, these tags should also reflect what actually the test does.

eduard13 · 2021-01-06T08:01:47Z

@magento run WebAPI Tests

engcom-Echo · 2021-01-06T09:06:55Z

@magento run all tests

eduard13

Good job on refactoring that ActionGroup. May you also address the below small suggestions?

Thank you.

eduard13 · 2021-01-06T09:14:56Z

app/code/Magento/Bundle/Test/Mftf/ActionGroup/AssertAdminErrorIsNotVisibleActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertAdminErrorIsNotVisibleActionGroup">


Lets also add a better name: AssertAdminErrorIsNotVisibleForProductFieldActionGroup.

Suggested change

<actionGroup name="AssertAdminErrorIsNotVisibleActionGroup">

<actionGroup name="AssertAdminErrorIsNotVisibleForProductFieldActionGroup">

eduard13 · 2021-01-06T09:15:22Z

app/code/Magento/Bundle/Test/Mftf/ActionGroup/AssertAdminErrorIsVisibleActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertAdminErrorIsVisibleActionGroup">


Suggested change

<actionGroup name="AssertAdminErrorIsVisibleActionGroup">

<actionGroup name="AssertAdminErrorIsVisibleForProductFieldActionGroup">

eduard13 · 2021-01-06T09:18:27Z

app/code/Magento/Bundle/Test/Mftf/Section/AdminProductFormBundleSection.xml

@@ -69,6 +69,7 @@
        <element name="priceField" type="input" selector="//div[@data-index='price']//input"/>
        <element name="listedBundleItem" type="text" selector="//tr[@data-repeat-index='0']//div"/>
        <element name="listedBundleItem2" type="text" selector="//tr[@data-repeat-index='2']//div"/>
+        <element name="fieldError" type="text" selector="//div[@data-index='{{fieldIndex}}']//following-sibling::label[@class='admin__field-error']" parameterized="true"/>


Is this selector also applicable for all the product types? If yes, let's move it to AdminProductFormSection.

eduard13 · 2021-01-06T09:20:44Z

app/code/Magento/Bundle/Test/Mftf/ActionGroup/AssertAdminErrorIsVisibleActionGroup.xml

+            <argument name="fieldIndex" type="string"/>
+        </arguments>
+
+        <seeElement selector="{{AdminProductFormBundleSection.fieldError(fieldIndex)}}" stepKey="seeError"/>


In case the selector applies to all products.

Suggested change

<seeElement selector="{{AdminProductFormBundleSection.fieldError(fieldIndex)}}" stepKey="seeError"/>

<seeElement selector="{{AdminProductFormSection.fieldError(fieldIndex)}}" stepKey="seeError"/>

eduard13 · 2021-01-06T09:21:19Z

app/code/Magento/Bundle/Test/Mftf/ActionGroup/AssertAdminErrorIsNotVisibleActionGroup.xml

+            <argument name="fieldIndex" type="string"/>
+        </arguments>
+
+        <dontSeeElement selector="{{AdminProductFormBundleSection.fieldError(fieldIndex)}}" stepKey="seeError"/>


In case the selector applies to all products.

Suggested change

<dontSeeElement selector="{{AdminProductFormBundleSection.fieldError(fieldIndex)}}" stepKey="seeError"/>

<dontSeeElement selector="{{AdminProductFormSection.fieldError(fieldIndex)}}" stepKey="seeError"/>

zakdma · 2021-01-19T09:00:29Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2021-01-19T09:05:52Z

@zakdma, an error occurred during the Pull Request import.

magento-engcom-team · 2021-01-19T09:08:47Z

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31501.

m2-assistant · 2021-01-20T20:02:18Z

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Area: Frontend Component: Bundle Component: Ui Release Line: 2.4 labels Jan 4, 2021

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 4, 2021

m2-community-project bot added the Progress: pending review label Jan 4, 2021

engcom-Echo requested review from engcom-Kilo, viktorpetryk and zakdma January 4, 2021 08:21

eduard13 self-assigned this Jan 5, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 5, 2021

eduard13 self-requested a review January 5, 2021 08:52

eduard13 requested changes Jan 5, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 5, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Jan 5, 2021

eduard13 requested changes Jan 6, 2021

View reviewed changes

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Jan 13, 2021

engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jan 13, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels Jan 13, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jan 13, 2021

magento-engcom-team added the Component: Catalog label Jan 13, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Jan 13, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jan 13, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Jan 13, 2021

magento-engcom-team merged commit d5d5372 into magento:2.4-develop Jan 20, 2021

gabrieldagama added the Type: Bug Fix label Mar 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MC-30152: Bundle Product / Create / Price validation for dynamic price #31501

MC-30152: Bundle Product / Create / Price validation for dynamic price #31501

engcom-Echo commented Jan 4, 2021 •

edited

Loading

m2-assistant bot commented Jan 4, 2021

engcom-Echo commented Jan 4, 2021

engcom-Echo commented Jan 4, 2021

eduard13 commented Jan 5, 2021

eduard13 left a comment

eduard13 Jan 5, 2021

engcom-Echo Jan 5, 2021

eduard13 Jan 5, 2021

engcom-Echo Jan 5, 2021 •

edited

Loading

eduard13 Jan 6, 2021

eduard13 Jan 5, 2021

eduard13 commented Jan 6, 2021

engcom-Echo commented Jan 6, 2021

eduard13 left a comment

eduard13 Jan 6, 2021

eduard13 Jan 6, 2021

eduard13 Jan 6, 2021

eduard13 Jan 6, 2021

eduard13 Jan 6, 2021

zakdma commented Jan 19, 2021

magento-engcom-team commented Jan 19, 2021

magento-engcom-team commented Jan 19, 2021

m2-assistant bot commented Jan 20, 2021

	<actionGroup name="AssertAdminErrorIsNotVisibleActionGroup">
	<actionGroup name="AssertAdminErrorIsNotVisibleForProductFieldActionGroup">

	<actionGroup name="AssertAdminErrorIsVisibleActionGroup">
	<actionGroup name="AssertAdminErrorIsVisibleForProductFieldActionGroup">

	<seeElement selector="{{AdminProductFormBundleSection.fieldError(fieldIndex)}}" stepKey="seeError"/>
	<seeElement selector="{{AdminProductFormSection.fieldError(fieldIndex)}}" stepKey="seeError"/>

	<dontSeeElement selector="{{AdminProductFormBundleSection.fieldError(fieldIndex)}}" stepKey="seeError"/>
	<dontSeeElement selector="{{AdminProductFormSection.fieldError(fieldIndex)}}" stepKey="seeError"/>

MC-30152: Bundle Product / Create / Price validation for dynamic price #31501

MC-30152: Bundle Product / Create / Price validation for dynamic price #31501

Conversation

engcom-Echo commented Jan 4, 2021 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Jan 4, 2021

engcom-Echo commented Jan 4, 2021

engcom-Echo commented Jan 4, 2021

eduard13 commented Jan 5, 2021

eduard13 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

engcom-Echo Jan 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eduard13 commented Jan 6, 2021

engcom-Echo commented Jan 6, 2021

eduard13 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zakdma commented Jan 19, 2021

magento-engcom-team commented Jan 19, 2021

magento-engcom-team commented Jan 19, 2021

m2-assistant bot commented Jan 20, 2021

engcom-Echo commented Jan 4, 2021 •

edited

Loading

engcom-Echo Jan 5, 2021 •

edited

Loading