Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CliIndexerReindexActionGroup action group usage for modules (mix) #31851

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jan 27, 2021

Description

Removed usage or changed value of CliIndexerReindexActionGroup action group for the following modules: Elasticsearch, Elasticsearch6, LayeredNavigation, LoginAsCustomer, Newsletter, UrlRewrite, Weee, Wishlist

Resolved issues:

  1. resolves [Issue] Removed CliIndexerReindexActionGroup action group usage for modules (mix) #31852: Removed CliIndexerReindexActionGroup action group usage for modules (mix)

@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2021

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

@magento create issue

@sergiy-v
Copy link
Contributor Author

@magento run all tests

@sergiy-v sergiy-v changed the title Removed CliIndexerReindexActionGroup action group usage for modules (mix) [WIP]Removed CliIndexerReindexActionGroup action group usage for modules (mix) Jan 27, 2021
@sergiy-v sergiy-v force-pushed the mftf-CliIndexerReindexActionGroup-usage-mix-modules branch from bb435b8 to 4cfff44 Compare January 27, 2021 12:30
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

2 similar comments
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run WebAPI Tests, Unit Tests, Static Tests, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Magento Health Index, Integration Tests, Database Compare

@sergiy-v sergiy-v changed the title [WIP]Removed CliIndexerReindexActionGroup action group usage for modules (mix) Removed CliIndexerReindexActionGroup action group usage for modules (mix) Jan 28, 2021
@sergiy-v
Copy link
Contributor Author

Everything are green, @rogyar please proceed with review.

@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 28, 2021
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8796 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

QA not applicable

@m2-assistant
Copy link

m2-assistant bot commented Mar 7, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliIndexerReindexActionGroup action group usage for modules (mix)
5 participants