Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReadMe] updated readMe file for MediaGallery-MediaStorage modules #31894

Merged
merged 1 commit into from
Oct 24, 2021
Merged

[ReadMe] updated readMe file for MediaGallery-MediaStorage modules #31894

merged 1 commit into from
Oct 24, 2021

Conversation

vlmed
Copy link
Contributor

@vlmed vlmed commented Jan 29, 2021

Description (*)

Update README.md file for modules:

  • Magento_MediaGallery
  • Magento_MediaGalleryApi
  • Magento_MediaGalleryCatalog
  • Magento_MediaGalleryCatalogIntegration
  • Magento_MediaGalleryCatalogUi
  • Magento_MediaGalleryCmsUi
  • Magento_MediaGalleryIntegration
  • Magento_MediaGalleryMetadata
  • Magento_MediaGalleryMetadataApi
  • Magento_MediaGalleryRenditions
  • Magento_MediaGalleryRenditionsApi
  • Magento_MediaGallerySynchronization
  • Magento_MediaGallerySynchronizationApi
  • Magento_MediaGallerySynchronizationMetadata
  • Magento_MediaGalleryUi
  • Magento_MediaGalleryUiApi
  • Magento_MediaStorage

Fixed Issues (if relevant)

  1. magento/devdocs README content for modules - work in M2 Code devdocs#4451: README content for modules - work in M2 Code

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 29, 2021

Hi @vlmed. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: multiple Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2021
@vlmed vlmed force-pushed the update_readme_nedia-gallery_media-storage branch 3 times, most recently from 4d78920 to 6b819be Compare February 4, 2021 13:31
@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 25, 2021
@bgorski bgorski self-requested a review July 10, 2021 13:29
@bgorski bgorski self-assigned this Jul 10, 2021
@bgorski
Copy link
Contributor

bgorski commented Jul 10, 2021

@vlmed thank you for your contribution! I had just one comment, the rest looks good to me. Please also resolve conflicts and we can proceed with this one.

@vlmed vlmed force-pushed the update_readme_nedia-gallery_media-storage branch from 6b819be to a1f384c Compare July 13, 2021 12:53
@vlmed
Copy link
Contributor Author

vlmed commented Jul 13, 2021

@bgorski thank you for the review. I have added SearchAssetsInterface and fixed conflicts.

@bgorski
Copy link
Contributor

bgorski commented Jul 26, 2021

@vlmed approved, thank you for the contribution!

@engcom-Charlie engcom-Charlie self-assigned this Jul 28, 2021
@BarnyShergold
Copy link

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@BarnyShergold
Copy link

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@BarnyShergold
Copy link

@magento run Functional Tests B2B,Functional Tests CE,Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@BarnyShergold
Copy link

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@BarnyShergold
Copy link

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@BarnyShergold
Copy link

@vlmed - All the tests have passed but the CLA seems stuck or not correct. I'm assuming that you have signed this? One way to kick this (we use this on DEVDOCS) is to Close then reopen the PR - what do you want to try?

@sidolov sidolov closed this Sep 23, 2021
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2021

Hi @vlmed, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov reopened this Sep 23, 2021
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2021

Hi @vlmed. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-9229 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sidolov sidolov mentioned this pull request Oct 24, 2021
Closed
magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2021
@sidolov
ENGCOM-9229: [ReadMe] updated readMe file for MediaGallery-MediaStora…
5493088 
…ge modules #31894
@magento-engcom-team magento-engcom-team merged commit f399b27 into magento:2.4-develop Oct 24, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2021

Hi @vlmed, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgorski bgorski bgorski approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@bgorski bgorski

@BarnyShergold BarnyShergold

@sidolov sidolov

@engcom-Charlie engcom-Charlie

Labels
Component: multiple Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vlmed @bgorski @engcom-Charlie @BarnyShergold @magento-engcom-team @sidolov @gabrieldagama