Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed CliCacheFlushActionGroup usage for Sales module #31936

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Removed CliCacheFlushActionGroup usage for Sales module #31936

merged 2 commits into from
Feb 18, 2021

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Feb 2, 2021 •
edited by m2-assistant bot
Loading

Description

Removed CliCacheFlushActionGroup usage for Sales, SalesRule, Search, Shipping and Store modules.

Resolved issues:

  1. resolves [Issue] Removed CliCacheFlushActionGroup usage for Sales module #31937: Removed CliCacheFlushActionGroup usage for Sales module

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2021

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Feb 2, 2021

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Feb 2, 2021
Closed
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Feb 2, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@ihor-sviziev ihor-sviziev self-assigned this Feb 2, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Magento Health Index, Semantic Version Checker, Static Tests

@ihor-sviziev
Copy link
Contributor

@sivaschenko magento don't want to run tests. could you check that?

@gabrieldagama
Copy link
Contributor

@magento run all tests

@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 2, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Feb 2, 2021

@magento run Functional Tests EE

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Feb 2, 2021
@engcom-Alfa engcom-Alfa self-assigned this Feb 3, 2021
@engcom-Alfa
Copy link
Contributor

QA not applicable

@sergiy-v
Merge branch '2.4-develop' into mftf-CliCacheFlushActionGroup-usage-s…
bb0460f 
…ales

# Conflicts:
#	app/code/Magento/Sales/Test/Mftf/Test/AdminCancelTheCreatedOrderWithCheckMoneyOrderPaymentMethodTest.xml
#	app/code/Magento/Sales/Test/Mftf/Test/AdminCancelTheCreatedOrderWithPurchaseOrderPaymentMethodTest.xml
#	app/code/Magento/Sales/Test/Mftf/Test/AdminReorderWithCatalogPriceRuleDiscountTest.xml
#	app/code/Magento/Sales/Test/Mftf/Test/CreateOrderFromEditCustomerPageTest.xml
#	app/code/Magento/Sales/Test/Mftf/Test/StorefrontOrderPagerDisplayedTest.xml
#	app/code/Magento/SalesRule/Test/Mftf/Test/StorefrontCartTotalValueWithFullDiscountUsingCartRuleTest.xml
#	app/code/Magento/Search/Test/Mftf/Test/StorefrontVerifySearchSuggestionByProductDescriptionTest.xml
#	app/code/Magento/Search/Test/Mftf/Test/StorefrontVerifySearchSuggestionByProductNameTest.xml
#	app/code/Magento/Search/Test/Mftf/Test/StorefrontVerifySearchSuggestionByProductShortDescriptionTest.xml
#	app/code/Magento/Search/Test/Mftf/Test/StorefrontVerifySearchSuggestionByProductSkuTest.xml
#	app/code/Magento/Store/Test/Mftf/Test/StorefrontCheckSortOrderStoreViewTest.xml
@sergiy-v
Copy link
Contributor Author

@magento run all tests

@sergiy-v
Copy link
Contributor Author

Hello @sergiy-v,
Could you please resolve conflicts?

Hello @engcom-Hotel.
The conflicts has been resolved. Will check tests result later today.
Thank you.

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

2 similar comments
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8721 has been created to process this Pull Request

@sergiy-v
Copy link
Contributor Author

@engcom-Hotel all tests are green, please proceed.
Thank you.

@engcom-Delta engcom-Delta self-assigned this Feb 15, 2021
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

magento-engcom-team pushed a commit that referenced this pull request Feb 18, 2021
@gabrieldagama
ENGCOM-8721: Removed CliCacheFlushActionGroup usage for Sales module #…
300287e 
…31936
@magento-engcom-team magento-engcom-team merged commit 73dacbf into magento:2.4-develop Feb 18, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Delta engcom-Delta

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Component: SalesRule Component: Search Component: Shipping Component: Store Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Code Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliCacheFlushActionGroup usage for Sales module
7 participants
@sergiy-v @ihor-sviziev @gabrieldagama @engcom-Alfa @engcom-Hotel @magento-engcom-team @engcom-Delta