Fix static tests to be php8 compatible #34192

karyna-t · 2021-09-29T12:24:40Z

Description (*)

Stabilisation of Static Tests to be compatible both with PHP7 and PHP8.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Stabilize Static Tests #34188

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-09-29T12:24:42Z

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

karyna-t · 2021-09-30T07:52:08Z

...s/static/testsuite/Magento/Test/Integrity/Magento/Framework/Api/ExtensibleInterfacesTest.php

@@ -135,7 +135,7 @@ private function checkSetExtensionAttributes(
            } else {
                // Get the parameter name via a regular expression capture because the class may
                // not exist which causes a fatal error
-                preg_match('/\[\s\<\w+?>\s([\w]+)/s', $methodParameters[0]->__toString(), $matches);
+                preg_match('/\[\s\<\w+?>\s([?]?[\w]+)/s', $methodParameters[0]->__toString(), $matches);


PHP 8
Parameter #0 [ ?Magento\MediaGalleryApi\Api\Data\KeywordExtensionInterface $extensionAttributes ]

PHP 7
Parameter #0 [ Magento\MediaGalleryApi\Api\Data\KeywordExtensionInterface or NULL $extensionAttributes ]

Could you please revise this check to be sure it works as expected ? With this regex /\[\s\<\w+?>\s([?]?[\w]+)/s we will have just first part of FQCN in $matches[1]. that mean that any parameter type will be considered correct as \Magento != \Mageno\Module\Api\Data\SomeExtensionInterface

karyna-t · 2021-09-30T11:36:48Z

@magento run Static Tests with env PHP 8.0

magento-automated-testing · 2021-09-30T11:36:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-09-30T11:38:10Z

@magento run Static Tests

magento-automated-testing · 2021-09-30T11:38:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-09-30T12:54:54Z

@magento run Static Tests

magento-automated-testing · 2021-09-30T12:55:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-30T13:02:02Z

@magento run Static Tests with env PHP 8.0

magento-automated-testing · 2021-09-30T13:02:06Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-09-30T18:20:55Z

@magento run Static Tests

magento-automated-testing · 2021-09-30T18:21:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-10-01T06:34:35Z

@magento run Static Tests

magento-automated-testing · 2021-10-01T06:34:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-10-01T07:17:48Z

@magento run Static Tests

magento-automated-testing · 2021-10-01T07:17:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-10-01T07:18:00Z

@magento run Static Tests with env PHP 8.0

magento-automated-testing · 2021-10-01T07:18:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-10-01T10:57:30Z

@magento run all tests with env PHP 8.0

magento-automated-testing · 2021-10-01T10:57:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-10-01T10:57:41Z

@magento run all tests

magento-automated-testing · 2021-10-01T10:57:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

xmav · 2021-10-01T22:20:23Z

dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php

@@ -127,6 +127,7 @@ private function getPluginBlacklist(): array
            );
            $blacklistItems = [];
            foreach (glob($blacklistFiles) as $fileName) {
+                // phpcs:ignore Magento2.Performance.ForeachArrayMerge


Could you please try to rewrite it using example from - magento/magento-coding-standard#20

xmav · 2021-10-01T22:20:34Z

dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php

@@ -243,6 +244,7 @@ protected function _phpClassesDataProvider()
        $allowedFiles = array_keys($classes);
        foreach ($classes as $class) {
            if (!in_array($class, $output)) {
+                // phpcs:ignore Magento2.Performance.ForeachArrayMerge


Could you please try to rewrite it using example from - magento/magento-coding-standard#20

xmav · 2021-10-02T05:40:34Z

...s/static/testsuite/Magento/Test/Integrity/Magento/Framework/Api/ExtensibleInterfacesTest.php

@@ -135,7 +135,7 @@ private function checkSetExtensionAttributes(
            } else {
                // Get the parameter name via a regular expression capture because the class may
                // not exist which causes a fatal error
-                preg_match('/\[\s\<\w+?>\s([\w]+)/s', $methodParameters[0]->__toString(), $matches);
+                preg_match('/\[\s\<\w+?>\s([?]?[\w]+)/s', $methodParameters[0]->__toString(), $matches);


Could you please revise this check to be sure it works as expected ? With this regex /\[\s\<\w+?>\s([?]?[\w]+)/s we will have just first part of FQCN in $matches[1]. that mean that any parameter type will be considered correct as \Magento != \Mageno\Module\Api\Data\SomeExtensionInterface

karyna-t · 2021-10-04T13:38:17Z

@magento run Static Tests with env PHP 8.0

magento-automated-testing · 2021-10-04T13:38:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-assistant · 2021-10-04T15:38:51Z

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 29, 2021

karyna-t changed the title ~~[WIP] Php8 compatibility/fix static tests to be php8 compatible~~ Fix static tests to be php8 compatible Sep 30, 2021

m2-community-project bot added the Progress: pending review label Sep 30, 2021

karyna-t force-pushed the php8-compatibility/fix-static-tests-to-be-php8-compatible branch from b9b51db to d05c3d6 Compare September 30, 2021 07:46

karyna-t commented Sep 30, 2021

View reviewed changes

sidolov added the Project: Platform Health label Sep 30, 2021

karyna-t changed the title ~~Fix static tests to be php8 compatible~~ [WIP] Fix static tests to be php8 compatible Sep 30, 2021

Fix static tests for php8 compatibility

0bf7b7f

karyna-t force-pushed the php8-compatibility/fix-static-tests-to-be-php8-compatible branch from 13629e7 to 0bf7b7f Compare October 1, 2021 07:17

m2-community-project bot removed the Progress: pending review label Oct 1, 2021

andrewbess changed the title ~~[WIP] Fix static tests to be php8 compatible~~ Fix static tests to be php8 compatible Oct 1, 2021

m2-community-project bot added Progress: pending review and removed Progress: ready for testing labels Oct 1, 2021

andrewbess self-assigned this Oct 1, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 1, 2021

eduard13 self-assigned this Oct 1, 2021

xmav suggested changes Oct 2, 2021

View reviewed changes

m2-community-project bot assigned xmav Oct 2, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Oct 2, 2021

karyna-t added 2 commits October 4, 2021 13:46

code review improvements

5481d43

fix static test fail

066b93c

xmav approved these changes Oct 4, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Oct 4, 2021

magento-devops-reposync-svc merged commit 3c11181 into magento:platform-health Oct 4, 2021

karyna-t deleted the php8-compatibility/fix-static-tests-to-be-php8-compatible branch October 29, 2021 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix static tests to be php8 compatible #34192

Fix static tests to be php8 compatible #34192

karyna-t commented Sep 29, 2021

m2-assistant bot commented Sep 29, 2021

karyna-t Sep 30, 2021

xmav Oct 2, 2021

karyna-t commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

karyna-t commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

karyna-t commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

andrewbess commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

karyna-t commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

karyna-t commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

karyna-t commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

karyna-t commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

andrewbess commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

andrewbess commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

xmav Oct 1, 2021

xmav Oct 1, 2021

xmav Oct 2, 2021

karyna-t commented Oct 4, 2021

magento-automated-testing bot commented Oct 4, 2021

m2-assistant bot commented Oct 4, 2021

Fix static tests to be php8 compatible #34192

Fix static tests to be php8 compatible #34192

Conversation

karyna-t commented Sep 29, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

m2-assistant bot commented Sep 29, 2021

karyna-t Sep 30, 2021

Choose a reason for hiding this comment

xmav Oct 2, 2021

Choose a reason for hiding this comment

karyna-t commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

karyna-t commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

karyna-t commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

andrewbess commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

karyna-t commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

karyna-t commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

karyna-t commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

karyna-t commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

andrewbess commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

andrewbess commented Oct 1, 2021

magento-automated-testing bot commented Oct 1, 2021

xmav Oct 1, 2021

Choose a reason for hiding this comment

xmav Oct 1, 2021

Choose a reason for hiding this comment

xmav Oct 2, 2021

Choose a reason for hiding this comment

karyna-t commented Oct 4, 2021

magento-automated-testing bot commented Oct 4, 2021

m2-assistant bot commented Oct 4, 2021