Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS Page provider returns result with 'id' #34909

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

mandarzope
Copy link

Description (*)

CMS Page provider results contained page_id instead of id

Fixed Issues (if relevant)

  1. Fixes Magento Graph QL : route query product and cms-page caching issue #34908

Manual testing scenarios (*)

  1. Install Magento 2.4 and install sample data
  2. execute GraphQL query query { route(url: "home") { __typename relative_url redirect_code } }
  3. X-Magento-Tags response header should contain 'cms_p,cms_p_2'

Questions or comments

Contribution checklist (*)

  • [ *] Pull request has a meaningful description of its purpose
  • [* ] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 1, 2022

Hi @mandarzope. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jan 1, 2022
@mandarzope mandarzope closed this Jan 2, 2022
@mandarzope mandarzope reopened this Jan 2, 2022
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Jan 2, 2022
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jan 2, 2022
@m2-community-project m2-community-project bot added Progress: pending review Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Jan 2, 2022
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Jan 5, 2022
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Nov 27, 2022
@ishakhsuvarov ishakhsuvarov removed this from Review in Progress in High Priority Pull Requests Dashboard Dec 8, 2022
@ishakhsuvarov ishakhsuvarov added this to Pending Review in Pull Requests Dashboard Dec 8, 2022
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Apr 25, 2023
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel engcom-Hotel self-requested a review May 16, 2023 13:10
@engcom-Hotel engcom-Hotel moved this from Pending Review to Review in Progress in Pull Requests Dashboard May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CmsUrlRewriteGraphQl Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review Release Line: 2.4
Projects
Pull Requests Dashboard
  
Review in Progress
Development

Successfully merging this pull request may close these issues.

Magento Graph QL : route query product and cms-page caching issue
5 participants