Issue 35838: Customer is logged in but showing 404 error in frontend. #36263

rogerdz · 2022-10-10T15:26:29Z

Description (*)

Remove referrer in url when current page 404, after customer login will redirect to Customer dashboard

Fixed Issues (if relevant)

Fixes Customer is logged in but showing 404 error in frontend. #35838

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2022-10-10T15:26:32Z

Hi @rogerdz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rogerdz · 2022-10-10T15:27:26Z

@magento run all tests

magento-automated-testing · 2022-10-10T15:27:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

edenduong

Thank you for your contribution.
Could you please check my comment.

edenduong · 2022-10-12T00:28:56Z

app/code/Magento/Customer/Model/Url.php

@@ -256,4 +261,23 @@ private function getRequestReferrer()
        }
        return null;
    }
+
+    /**
+     *  Check if Referrer url is no route url


Redundant 1 Space character after *

edenduong · 2022-10-12T03:12:51Z

app/code/Magento/Customer/Model/Url.php

+    private function isNoRouteUrl($url)
+    {
+        $defaultNoRouteUrl = $this->scopeConfig->getValue(
+            'web/default/no_route',


It is better if declare private const XML_PATH_WEB_DEFAULT_NO_ROUTE = 'web/default/no_route'

Thank you for your advice, I added change to new commit

rogerdz · 2022-10-13T15:09:34Z

@magento run all tests

magento-automated-testing · 2022-10-13T15:09:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2022-10-13T23:50:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2022-10-13T23:50:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-12-19T07:31:06Z

@magento give me 2.4-develop instance

magento-deployment-service · 2022-12-19T07:31:08Z

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

engcom-Charlie · 2024-03-21T09:46:49Z

Before merge, sending it to testing again as it got move to merge after testing more than a year ago.

engcom-Delta · 2024-04-05T09:38:11Z

@magento run all tests

engcom-Delta · 2024-04-05T11:23:17Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Manual testing scenario:

1.Go to frontend.
2.Add /customer/account/loginPost/ in your magento url.
3.Now click on sign In
4.Give login id and password.

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Echo · 2024-05-16T07:27:45Z

@magento run Functional Tests EE, Functional Tests CE,Functional Tests B2B

engcom-Echo · 2024-05-16T13:44:11Z

Functional Tests EE, Functional Tests CE,Functional Tests B2B build failure are different on last two run on same commit also it contain some known failures.

Functional Tests EE
Run1

Run2

Functional Tests CE
Run1

Run2

Functional Tests B2B
Run1

Run2

Hence moving it to merge in progress.

Roger and others added 2 commits October 10, 2022 10:56

Issue 35838: Customer is logged in but showing 404 error in frontend

e0324ae

Issue 35838: add unit test

67f340b

m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Oct 10, 2022

m2-community-project bot added the Progress: pending review label Oct 10, 2022

edenduong requested changes Oct 12, 2022

View reviewed changes

m2-community-project bot assigned edenduong Oct 12, 2022

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Oct 12, 2022

rogerdz and others added 2 commits October 13, 2022 15:08

Issue 35838: update code

28d816f

Merge branch '2.4-develop' into issue-35838

63136c2

m2-community-project bot added Progress: review and removed Progress: needs update labels Oct 13, 2022

edenduong approved these changes Oct 13, 2022

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Oct 13, 2022

edenduong added the Component: Customer label Oct 13, 2022

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Dec 21, 2022

Merge branch '2.4-develop' into issue-35838

3d6a5de

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels Mar 21, 2024

engcom-Delta added Progress: testing in progress and removed Progress: ready for testing labels Apr 5, 2024

engcom-Delta self-assigned this Apr 5, 2024

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Apr 5, 2024

engcom-Delta added Progress: testing in progress and removed Progress: ready for testing labels Apr 5, 2024

engcom-Delta added Progress: extended testing and removed Progress: testing in progress labels Apr 5, 2024

m2-community-project bot added Progress: accept and removed Progress: extended testing labels May 16, 2024

magento-devops-reposync-svc merged commit 0b0f7c8 into magento:2.4-develop May 28, 2024
9 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 35838: Customer is logged in but showing 404 error in frontend. #36263

Issue 35838: Customer is logged in but showing 404 error in frontend. #36263

rogerdz commented Oct 10, 2022 •

edited

Loading

m2-assistant bot commented Oct 10, 2022

rogerdz commented Oct 10, 2022

magento-automated-testing bot commented Oct 10, 2022

edenduong left a comment

edenduong Oct 12, 2022

edenduong Oct 12, 2022

rogerdz Oct 13, 2022

rogerdz commented Oct 13, 2022

magento-automated-testing bot commented Oct 13, 2022

magento-automated-testing bot commented Oct 13, 2022

magento-automated-testing bot commented Oct 13, 2022

engcom-Lima commented Dec 19, 2022

magento-deployment-service bot commented Dec 19, 2022

engcom-Charlie commented Mar 21, 2024

engcom-Delta commented Apr 5, 2024

engcom-Delta commented Apr 5, 2024

engcom-Echo commented May 16, 2024

engcom-Echo commented May 16, 2024

Issue 35838: Customer is logged in but showing 404 error in frontend. #36263

Issue 35838: Customer is logged in but showing 404 error in frontend. #36263

Conversation

rogerdz commented Oct 10, 2022 • edited Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Oct 10, 2022

rogerdz commented Oct 10, 2022

magento-automated-testing bot commented Oct 10, 2022

edenduong left a comment

Choose a reason for hiding this comment

edenduong Oct 12, 2022

Choose a reason for hiding this comment

edenduong Oct 12, 2022

Choose a reason for hiding this comment

rogerdz Oct 13, 2022

Choose a reason for hiding this comment

rogerdz commented Oct 13, 2022

magento-automated-testing bot commented Oct 13, 2022

magento-automated-testing bot commented Oct 13, 2022

magento-automated-testing bot commented Oct 13, 2022

engcom-Lima commented Dec 19, 2022

magento-deployment-service bot commented Dec 19, 2022

engcom-Charlie commented Mar 21, 2024

engcom-Delta commented Apr 5, 2024

engcom-Delta commented Apr 5, 2024

✔️ QA Passed

engcom-Echo commented May 16, 2024

engcom-Echo commented May 16, 2024

rogerdz commented Oct 10, 2022 •

edited

Loading