Fix shipping total amount calculation for multishipping addresses

[ilnytskyi]

Description (*)

When Quote contains more than one shipping address, the total collector updates shipping amount for address given in $quote->getShippingAddress() instead of passed via $shippingAssignment

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Create a quote
2. Add additional shipping address with items
3. Leave address given via $quote->getShippingAddress() with virtual items only
4. Collect quote totals
5. The address given via $quote->getShippingAddress() has fields shipping_amount and base_shipping_amount equal 0.

Questions or comments

Currently that address would contain shipping_amount and base_shipping_amount greater than zero but shipping_incl_tax equals zero that is wrong for multishipping quotes

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix shipping total amount calculation for multishipping addresses #37283: Fix shipping total amount calculation for multishipping addresses

[m2-assistant]

Hi @ilnytskyi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ilnytskyi]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ilnytskyi]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ilnytskyi]

Failling tests seem not related to changes

[engcom-Bravo]

@magento create issue

[engcom-Hotel]

Hello @ilnytskyi,

Thanks for the contribution!

Please have a look at the comment here #37283 (comment) and let us know if we have missed anything in order to reproduce the issue.

Thanks

[engcom-Charlie]

Hi @engcom-Hotel,

As per this comment, moving this PR in Review now as the issue is confirmed.

Thank you!

[engcom-Hotel]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

Hello @ilnytskyi,

Thanks for the contribution!

It seems some builds are failing due to PR changes. We request you to please look into those and please cover the PR changes with some automated tests.

Thanks

[ilnytskyi]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[ilnytskyi]

@engcom-Hotel it looks like the build failing due to merge of the main branch. I do not see any failing tests related to checkout or multishipping

[ilnytskyi]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[ilnytskyi]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[ilnytskyi]

up

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hello @ilnytskyi,

No file changes are visible in this PR, so it will be closed for now. Please reopen if there are any updates or if something was missed.

Thanks.

[ilnytskyi]

@engcom-Dash dont know how, but my changes already in 2.4-develop branch - https://github.com/magento/magento2/blame/2.4-develop/app/code/Magento/Tax/Model/Sales/Total/Quote/Shipping.php#L41 so probalby merged within other PR