Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect loop when URL have uppercase #38539

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Redirect loop when URL have uppercase #38539

merged 10 commits into from
Nov 1, 2024
+59 −2

Conversation

rogerdz
Copy link
Contributor

@rogerdz rogerdz commented Mar 21, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Redirect loop when URL have uppercase #38538

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Mar 21, 2024

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@rogerdz
Copy link
Contributor Author

rogerdz commented Mar 21, 2024

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Mar 26, 2024
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Sep 12, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rogerdz,

Thanks for the contribution!

Please fix the failed tests.

Thanks

@engcom-Dash engcom-Dash self-assigned this Sep 18, 2024
@engcom-Dash
Copy link
Contributor

@magento give me test instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @engcom-Dash, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-Dash
Copy link
Contributor

Fixed failing unit tests so moving this back to pending review.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @engcom-Dash,

Please fix the below review comments as well.

Thanks

app/code/Magento/Config/Test/Unit/Model/Config/Backend/BaseurlTest.php Outdated
* @param string $expectedValue
* @return void
*/
public function testBeforeSaveConvertLowerCase($value, $expectedValue)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hints (string for parameters and void for return type)

app/code/Magento/Config/Test/Unit/Model/Config/Backend/BaseurlTest.php Show resolved Hide resolved
app/code/Magento/Config/Test/Unit/Model/Config/Backend/BaseurlTest.php Outdated
/**
* @return array
*/
public static function beforeSaveDataProvider()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a return type hint (array)

app/code/Magento/Config/Test/Unit/Model/Config/Backend/BaseurlTest.php Show resolved Hide resolved
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @rogerdz,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Run: php bin/magento con:set web/secure/base_url https://Magento2.test/ ( or change Secure Base URL value in admin)
  • Clean cache: php bin/magento cache:clean
  • Go to homepage

Before: ✖️ 

Screenshot 2024-09-24 at 11 35 32

After: ✔️

Screenshot 2024-09-24 at 11 48 43

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

hostep
hostep reviewed Sep 24, 2024
View reviewed changes
app/code/Magento/Config/Test/Unit/Model/Config/Backend/BaseurlTest.php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert back the file permissions on this file from 0755 to 0644, there's no good reason to change them to 0755 ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hostep, Reverted the file permissions.

@hostep hostep removed their assignment Sep 24, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Dash
Copy link
Contributor

The Functional B2B and EE test failures are not consistent in recent 2 builds. Seems to be flaky, hence moving it to Merge in Progress.
Functional B2B:
Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38539/97fba4c05927ed773c07ac5966214654/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/ce6350f35f68e89d/
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38539/30a6bc498427a4b59e1324aa693f15c4/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/d3d40d3f286a0c58/
image

Functional EE
Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38539/41e1c14f0e05ca541e402e6c731ced2f/Functional/allure-report-ee/index.html#categories/75b40a63f79830217aae704c6d6af940/de4531c7ce72aa00/
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38539/526ad0af24633476a36188d5f05e41bd/Functional/allure-report-ee/index.html#categories/75b40a63f79830217aae704c6d6af940/d3bd81128df7f8a5/
image

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 272c73b into magento:2.4-develop Nov 1, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hostep hostep hostep left review comments

@engcom-Dash engcom-Dash engcom-Dash left review comments

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Hotel engcom-Hotel

@engcom-Dash engcom-Dash

Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: review Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirect loop when URL have uppercase
8 participants
@rogerdz @engcom-Hotel @engcom-Dash @engcom-Bravo @engcom-Charlie @hostep @magento-devops-reposync-svc @Priyakshic