Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

String "Place Order" is not pulled from the Checkout module #75

wants to merge 3 commits into


None yet
3 participants

amenk commented Sep 4, 2012

The Place Order button is a Mage_Core_Block_Template instance and so the __ function tries to pull the translation from Mage_Core, not from Mage_Checkout as it is defined in the translation files.


amenk commented Sep 4, 2012

This is of a quite high importance as in Germany there are laws that allow only specific namings of the button that are not in effect because of this bug.

Yeah right. This Bug exists since Mage 1.4.x Made me confused.


magento-team commented Oct 9, 2012

Thank you for the valuable contribution. Proposed code changes have been incorporated into the internal repository, necessary tests have been added as well. Next time please supply pull requests with automated tests (unit or integration).

Changes will become available on the GitHub with one of the next merges from the internal repository.

Closing the ticket as complete. Thank you.


amenk commented Oct 9, 2012

Thanks for accepting my contribution. I am a little bit confused: How would an test for pulling a translation string look like??? Can you give an example?


magento-team commented Oct 9, 2012

Sure, here is a test using integration testing framework:

 * @magentoConfigFixture current_store general/locale/code de_DE
public function testReviewActionLocalization()
    $this->assertNotContains('Place Order', $this->getResponse()->getBody());
    $this->assertContains('Bestellung aufgeben', $this->getResponse()->getBody());

It will be available in one of next code updates.

We'd like to mention that this test is not ideal. The best fit for this case probably would be a combination of functional and unit test. But at the moment we don't publish functional tests and some Magento legacy code is nearly impossible to cover with unit test without substantial refactoring.

@magento-team magento-team added a commit that referenced this pull request Nov 12, 2012

@magento-team magento-team
* Framework changes
  * Added dependency injection of framework capability
    * Adopted Zend\Di component of Zend Framework 2 library
    * Implemented object manager in Magento application
    * Refactored multiple base classes to dependency injection principle (dependencies are declared in constructor)
  * Themes/View
    * Implemented storing themes registry in database, basic CRUD of themes, automatic registration of themes in database from file system out of the box
    * Renamed `Mage_Core_Model_Layout_Update` into `Mage_Core_Model_Layout_Merge`, the former becomes an entity domain model. Similar changes with `Mage_Core_Model_Resource_Layout` -> `Mage_Core_Model_Resource_Layout_Update`, `Mage_Core_Model_Layout_Data` -> `Mage_Core_Model_Layout_Update`
* Performance tests
  * Improved indexers running script `dev/shell/indexer.php` to return appropriate exit code upon success/failure
  * Implemented running the same performance scenario file with different parameters
  * Slightly refactored framework class `Magento_Performance_Testsuite_Optimizer` for better visibility of algorithm
* Visual design editor
  * Added ability to remove elements in editor UI
  * Revised history of changes VDE toolbar and algorithm of "compacting" operations (moving, removing elements) as a layout update XML
  * Added selection of themes to VDE launcher page
* Refactored JavaScript of some UI elements to jQuery:
  * "Simple" and "configurable" product view pages
  * "Create Account" page
  * "Shopping Cart" page
  * Newsletter subscription
* Tax management UX improvements
  * Split Basic and Advanced Settings for Tax Rule Management UI
  * Moved the Import/Export functionality to Tax Rate page
  * Moved Tax menu to System from Sales
* Implemented the editable multiselect JavaScript component
* Added mentioning sitemap in `robots.txt` after generation
* Removed creation of DB backup in integration testing framework
* Fixed logic of order of loading ACL resources in backend
* Fixed JavaScript error during installation when one of files in `pub/media` is not writable
* Fixed structure of legacy test fixtures that allowed ambiguous keys in declaration
* Fixed inability to restore admin password when CAPTCHA is enabled
* Various minor UX fixes (labels, buttons, redirects, etc...)
* GitHub requests:
  * [#59](#59) -- implemented handling of unexpected situations in admin/dashboard/tunnel action
  * [#66](#66)
    * refactored ImageMagick adapter unit test to avoid system operation
    * simplified unit testing framework -- removed unused classes, simplified handling logic of directory `dev/tests/unit/tmp` and removed it from VCS
  * [#73](#73), [#74](#74) -- fixes in docblock tags
  * [#75](#75), [#96](#96) -- fixed translation module contexts in a few places
  * [#80](#80) -- fixed some runtime errors in import/export module
  * [#81](#81) -- removed usage of "remove" directive in places where it is overridden by setting root template anyway
  * [#87](#87) -- changed paths of files to include from relative into absolute in `dev/shell/indexer.php` and `log.php`
  * [#88](#88) -- provided comments for values that can be configured in `app/etc/local.xml` file
  * [#90](#90) -- slightly optimized logic of implementation of loading configurable product attributes

@magento-team magento-team pushed a commit that referenced this pull request Feb 6, 2015

Michael Logvin Merge pull request #75 from magento-firedrakes/bugfixes
[Firedrakes] Bugfixes. Sprint 36

@joanhe joanhe pushed a commit that referenced this pull request Nov 17, 2015

He, Joan(johe) Merge pull request #75 from magento-extensibility/MAGETWO-43960-custo…

Magetwo 43960 custom timezone merged

@magento-team magento-team pushed a commit that referenced this pull request Mar 23, 2016

@uharbachou uharbachou Merge pull request #75 from ValeryYafremau/JS-361
JS-361: Magnifier is visible on mobile breakpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment