Don't skip attribute options with a value of 0 from the layered navigation #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@dcabrejasazagra thank you for your contribution |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Apr 21, 2022
…Ql_13042022 Hammer quality backlog graph ql 13042022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Steps to replicate :
Create an attribute to be used in the Layered Navigation using the source_model
Magento\Eav\Model\Entity\Attribute\Source\Boolean.When you are on a category page, on the layered navigation you are not given the option to filter by 'No' even though there are products in the category which have this value, you can only filter by 'Yes' because all the attribute options with a falsy value won't be available. 'No' has a falsy value of 0;
## Code Explanation
Make sure that attribute options with a numeric value are not skipped. Empty strings will still be skipped.