Security.txt module

[kalpmehta]

Description (*)

Security.txt module provides an implementation of the security.txt standard (https://tools.ietf.org/html/draft-foudil-securitytxt-06) in Magento.

README: https://github.com/kalpmehta/securitytxt/blob/master/Kalpesh/Securitytxt/README.md

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[ishakhsuvarov]

Some general comments:

• Looks like included images are unused
• All classes must be declared strict types and all methods must have strict parameter and return types in their signatures.
• Would be nice to run code through phpcs with the Magento rulest: https://github.com/magento/magento-coding-standard
• It's best to avoid protected visibility
• To accept the extension as a core extension we would need to change namespace to Magento and update copyrights with those used in core.

[kalpmehta]

Thanks @ishakhsuvarov for the detailed review! I will work on the recommendations.

[gwillem]

Thanks @kalpmehta for this contribution and @ishakhsuvarov for quality reviewing!

[ishakhsuvarov]

Looks like Securitytxt/.DS_Store is mistakenly added to version control

Outdated