security-package/issues/127: Updated Save Config Validation class. #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o security-package/issues/127 # Conflicts: # Securitytxt/Model/Config/Backend/Validate.php
engcom-Kilo
force-pushed
the
security-package/issues/127
branch
from
1d31b7d to
582fd09
Compare
Comment on lines
122
to
126
| $contactWebPage = ''; | ||
|
|
||
| if ($this->existDataValue($contactWebPageFieldData)) { | ||
| $contactWebPage = $this->getDataValue($contactWebPageFieldData); | ||
| } |
There was a problem hiding this comment.
Suggested change
| $contactWebPage = ''; | |
| if ($this->existDataValue($contactWebPageFieldData)) { | |
| $contactWebPage = $this->getDataValue($contactWebPageFieldData); | |
| } | |
| if ($this->existDataValue($contactWebPageFieldData)) { | |
| $contactWebPage = $this->getDataValue($contactWebPageFieldData); | |
| } else { | |
| $contactWebPage = ''; | |
| } |
Comment on lines
159
to
164
| $result = ''; | ||
| if (isset($fieldData['value'])) { | ||
| $result = $fieldData['value']; | ||
| } | ||
|
|
||
| return $result; |
There was a problem hiding this comment.
Suggested change
| $result = ''; | |
| if (isset($fieldData['value'])) { | |
| $result = $fieldData['value']; | |
| } | |
| return $result; | |
| return $fieldData['value'] ?: ''; |
There was a problem hiding this comment.
Seems this construction not working,
if not exist array element with key - value
Updated with following construction
return isset($fieldData['value']) ? $fieldData['value'] : '';
Comment on lines
175
to
181
| if (isset($fieldData['value'])) { | ||
| if ($fieldData['value'] !== '' || empty($fieldData['value'])) { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Suggested change
| if (isset($fieldData['value'])) { | |
| if ($fieldData['value'] !== '' || empty($fieldData['value'])) { | |
| return true; | |
| } | |
| } | |
| return false; | |
| return isset($fieldData['value']) && $fieldData['value'] !== ''; |
There was a problem hiding this comment.
Updated with following construction -
return isset($fieldData['value']) && ($fieldData['value'] !== '' || empty($fieldData['value']));
Because need also to check form data for empty value.
Comment on lines
193
to
197
| if ($this->existDataValue($fieldData[$key]) && $this->getDataValue($fieldData[$key]) === '') { | ||
| return true; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Suggested change
| if ($this->existDataValue($fieldData[$key]) && $this->getDataValue($fieldData[$key]) === '') { | |
| return true; | |
| } | |
| return false; | |
| return ($this->existDataValue($fieldData[$key]) && $this->getDataValue($fieldData[$key]) === ''); |
Comment on lines
208
to
214
| if ($this->isEmptyValue('email', $contactInformationFields) | ||
| && $this->isEmptyValue('phone', $contactInformationFields) | ||
| && $this->isEmptyValue('contact_page', $contactInformationFields)) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Suggested change
| if ($this->isEmptyValue('email', $contactInformationFields) | |
| && $this->isEmptyValue('phone', $contactInformationFields) | |
| && $this->isEmptyValue('contact_page', $contactInformationFields)) { | |
| return true; | |
| } | |
| return false; | |
| return $this->isEmptyValue('email', $contactInformationFields) | |
| && $this->isEmptyValue('phone', $contactInformationFields) | |
| && $this->isEmptyValue('contact_page', $contactInformationFields); |
Comment on lines
101
to
105
| $contactEmail = ''; | ||
|
|
||
| if ($this->existDataValue($contactEmailFieldData)) { | ||
| $contactEmail = $this->getDataValue($contactEmailFieldData); | ||
| } |
There was a problem hiding this comment.
Suggested change
| $contactEmail = ''; | |
| if ($this->existDataValue($contactEmailFieldData)) { | |
| $contactEmail = $this->getDataValue($contactEmailFieldData); | |
| } | |
| if ($this->existDataValue($contactEmailFieldData)) { | |
| $contactEmail = $this->getDataValue($contactEmailFieldData); | |
| } else { | |
| $contactEmail = ''; | |
| } |
naydav
suggested changes
Mar 24, 2020
| /** | ||
| * Validate Email | ||
| */ | ||
| $this->validateContactEmail($contactInformationFields['email']); |
There was a problem hiding this comment.
Will lead to PHP notice undefined key if "email" is not present. The same for the other cases.
Thanks
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
|
Need to change to |
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
Closing in favor of #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)