Skip to content

magento/security-package#127: Configuration cannot be saved in scope that is different from Default Config #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2020
Merged

magento/security-package#127: Configuration cannot be saved in scope that is different from Default Config #226

merged 2 commits into from
May 26, 2020

Conversation

lenaorobei
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Configuration cannot be saved in scope that is different from Default Config #127: Configuration cannot be saved in scope that is different from Default Config

Manual testing scenarios (*)

See issue

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lenaorobei lenaorobei mentioned this pull request May 21, 2020
Closed
5 tasks
@lenaorobei
Copy link
Contributor Author

@magento run all tests

@lenaorobei lenaorobei linked an issue May 21, 2020 that may be closed by this pull request
Configuration cannot be saved in scope that is different from Default Config #127
Closed
@lenaorobei lenaorobei added this to the 1.0.0 milestone May 21, 2020
@lenaorobei
Copy link
Contributor Author

@magento run Functional Tests B2B

@engcom-Delta engcom-Delta self-assigned this May 25, 2020
@engcom-Delta
Copy link

✔️ QA passed
Result:

  • Saved config for second website

image

  • Security.txt data for second website

image

image

@lenaorobei
Copy link
Contributor Author

@magento run all tests

@lenaorobei
Copy link
Contributor Author

AUR Functional https://m2build-ur.devops.magento.com/view/all/job/All-User-Requested-Tests/33073/

@lenaorobei lenaorobei merged commit 8aad7b0 into 1.0.0-develop May 26, 2020
@lenaorobei lenaorobei deleted the fix-127 branch June 10, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@engcom-Delta engcom-Delta

Labels
Component: securitytxt
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Configuration cannot be saved in scope that is different from Default Config
2 participants
@lenaorobei @engcom-Delta