Skip to content

Fix innodb efficiency suggestion #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
Merged

Fix innodb efficiency suggestion #841

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9de576b
Fix wrong innodb_log_buffer_size suggestion
google-labs-jules[bot] Aug 28, 2025
8dce1af
Fix wrong innodb_log_buffer_size suggestion
google-labs-jules[bot] Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions mysqltuner.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6766,7 +6766,10 @@ sub mysql_innodb {
}

# InnoDB Read efficiency
if ( defined $mycalc{'pct_read_efficiency'}
if ( $mystat{'Innodb_buffer_pool_reads'} > $mystat{'Innodb_buffer_pool_read_requests'} ) {
infoprint "InnoDB Read buffer efficiency: metrics are not reliable (reads > read requests)";
}
elsif ( defined $mycalc{'pct_read_efficiency'}
&& $mycalc{'pct_read_efficiency'} < 90 )
{
badprint "InnoDB Read buffer efficiency: "
Expand All @@ -6788,7 +6791,10 @@ sub mysql_innodb {
}

# InnoDB Write efficiency
if ( defined $mycalc{'pct_write_efficiency'}
if ( $mystat{'Innodb_log_writes'} > $mystat{'Innodb_log_write_requests'} ) {
infoprint "InnoDB Write Log efficiency: metrics are not reliable (writes > write requests)";
}
elsif ( defined $mycalc{'pct_write_efficiency'}
&& $mycalc{'pct_write_efficiency'} < 90 )
{
badprint "InnoDB Write Log efficiency: "
Expand Down