Skip to content

nec/pc8801.cpp: promote machines to working status #10685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 19, 2022
Merged

nec/pc8801.cpp: promote machines to working status #10685

merged 15 commits into from
Dec 19, 2022

Conversation

angelosa
Copy link
Member

@angelosa angelosa commented Dec 14, 2022

  • video/upd3301.cpp: fix off by one attribute bugs happening for pc8801 N-88 Basic and several other entries;
  • nec/pc8801.cpp: backported centronics hookup from pc8001, allows supporting Jast Sound thru Covox interface in some Jast entries;
  • nec/pc8801.cpp: fix 1bpp graphic layer drawing when uPD3301 is not in color mode, fixes byoin regression;

Machines promoted to working

nec/pc8801.cpp: PC-8801mkIISR, PC-8801MH, PC-8801MA [Angelo Salese, Oliver Galibert, Carl]

Clones promoted to working

nec/pc8801.cpp: PC-8801mkIIFR, PC-8801mkIIMR, PC-8801FA, PC-8801MA2 [Angelo Salese, Oliver Galibert, Carl]

New working software list additions

pc8801_flop.xml: D' (cracked) [Neo Kobe], Donkey Kong 3 - Dai Gyakushuu [Game Preservation Society, Carl, Disk Blitz]

New NOT_WORKING software list additions

pc8801_flop.xml: D' (alt) [Neo Kobe]

@angelosa
Copy link
Member Author

angelosa commented Dec 14, 2022

I'll try to do my best in updating the SW list before code freeze, @cuavas remind me if I need to explicitly make a commit for the promotion message or being in the PR body is enough (including catching SW list children).

angelosa and others added 8 commits December 14, 2022 05:04
-----------------------------------
pc8801_flop.xml: D' (cracked) [Neo Kobe]

New NOT_WORKING software list additions
---------------------------------------
pc8801_flop.xml: D' (alt) [Neo Kobe]
-----------------------------------
pc8801_flop.xml: Donkey Kong 3 The Great Counterattack [Game Preservation Society, Carl, Disk Blitz]
@angelosa angelosa marked this pull request as ready for review December 18, 2022 03:43
@angelosa
Copy link
Member Author

Marked ready, will be applied tomorrow if there's no objection.

@angelosa angelosa merged commit d75885a into master Dec 19, 2022
@angelosa angelosa deleted the pc88qa branch December 19, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants