Skip to content

Conversation

MooglyGuy
Copy link
Contributor

supracan: Hooked up internal 68k boot ROM, externalized key. [Ryan Holtz, wxhsplash]

@MooglyGuy
Copy link
Contributor Author

There could be a better way of handling the views for the internal ROM. I'm open to suggestions.

@angelosa
Copy link
Member

angelosa commented Nov 4, 2023

There could be a better way of handling the views for the internal ROM. I'm open to suggestions.

The best way is to move this to a bus slot that address_map to a single entity, cfr. bus/a800/a800_slot.cpp.
It's imho a nice to have unless any of the games also needs EEPROM/backup RAM in the meantime.

@MooglyGuy
Copy link
Contributor Author

There could be a better way of handling the views for the internal ROM. I'm open to suggestions.

The best way is to move this to a bus slot that address_map to a single entity, cfr. bus/a800/a800_slot.cpp. It's imho a nice to have unless any of the games also needs EEPROM/backup RAM in the meantime.

The use of a memory view is based on how the Game Boy driver does it, and I'm more likely to believe that one's a more modern implementation. It's not the use of a view that I was wondering about, it's that it looks like the internal ROM is mirrored at 0xF80000 at one point during the last phases of theboot sequence. I'm currently handling it via a second view, but there might be a better way.

@rb6502 rb6502 merged commit 7c0909c into mamedev:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants