Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midway/williams.cpp, wmg.cpp: Various cleanups #12246

Merged
merged 4 commits into from
Apr 14, 2024

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Apr 14, 2024

Use memory_view for ROM/Palette overlay
Reduce unnecessary devices, variables
Reduce ROM region size, rearrange ROM offsets
Fix naming for tile ROM region
Reduce runtime tag lookups
suppress machine().side_effects_disabled() for debugger reading PIA constantize variables

cam900 and others added 4 commits April 14, 2024 16:12
Use memory_view for ROM/Palette overlay
Reduce unnecessary devices, variables
Reduce ROM region size, rearrange ROM offsets
Fix naming for tile ROM region
Reduce runtime tag lookups
suppress machine().side_effects_disabled() for debugger reading PIA
constantize variables
@cuavas cuavas merged commit 330964e into mamedev:master Apr 14, 2024
5 checks passed
@cuavas
Copy link
Member

cuavas commented Apr 14, 2024

This causes defender and other games with the same configuration to crash. I fixed it in 65b5718, but you should really test all the machine configurations you’re changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants