-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the BEXT instruction (part2) #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BEXT instruction is needed for the Unisonic Champion driver which I'm building. The Intellivision doesn't need it since its EBCA0, EBCA1,EBCA2 and EBCA3 pins are grounded. The method used was a suggestion from RB
ghost
mentioned this pull request
May 13, 2017
ghost
mentioned this pull request
Jul 11, 2017
superctr
added a commit
to superctr/mame
that referenced
this pull request
Aug 18, 2018
zsg2.cpp: Attempt to reduce clicks zsg2.cpp: Made the emphasis filter much more simple. I think this matches hardware, as a filter like this could be implemented with very few gates in hardware. Also reset the filter state when the sample position reaches the start address, this fixes raycris song mamedev#9 taito_zm.cpp: Adjust volume balance, hopefully fixing psyvarrv. I would need hardware recording for proper verification though tms57002: forgot MACC pipelining for some instructions
rb6502
pushed a commit
that referenced
this pull request
Aug 18, 2018
* taito_zm.cpp : Updates Add DSP, Reduce MCFGs, Add device_mixer_interface for sound gain, Add imperfect_features related to DSP, Add notes * taito_zm.cpp : Fix TMS57002 clock * Improve Taito Zoom ZSG-2 sound emulation zsg2.cpp: implement emphasis filter, this is a noise reduction scheme that amplifies higher frequncies to reduce quantization noise. zsg2.cpp: Add sample interpolation and another adjustable lowpass filter. This seems to be roughly what real hardware does... zsg2.cpp: Improve panning registers and identify DSP output gain registers. * zsg2: minor changes [nw] zsg2: Register 0b appears to be status flags [nw] zsg2: Linear ramping probably makes more sense [nw] * zsg2: slight adjustment of emphasis filter [nw] * zsg2: slight adjustment of emphasis filter #2 [nw] * zsg2: more sober ramping algorithm [nw] * tms57002: add instructions 3c/3d, make them behave as NOP as they're undocumented and not understood * tms57002: Add dready callback for superctr (nw) * tms57002: Fixes to make Taito Zoom DSP working tms57002: Add undocumented instruction saom / raom, they set saturation mode for the ALU. tms57002: Implement MACC pipeline. tms57002: Add callbacks for EMPTY and PC0 pins. tms57002: Add a few unimplemented instructions. tms57002: Proper behavior of CMEM UPLOAD mode. tms57002: Fix an issue where program is not properly loaded if PLOAD is set after a program has already been written. * Documentation fix, properly identified registers as ramping control, will implement that soon [nw] * taito_zm: Working DSP emulation Pretty much OST quality now. A pretty decent upgrade from how it was previously, I'd say. * typo [nw] * just adding some quick notes about the WIP [nw] * Fix build [nw] * zsg2: Proper ramping implemenation, add register map, minor cleanups * oops [nw] * taito_zm.cpp / zsg2.cpp - more improvements zsg2.cpp: Attempt to reduce clicks zsg2.cpp: Made the emphasis filter much more simple. I think this matches hardware, as a filter like this could be implemented with very few gates in hardware. Also reset the filter state when the sample position reaches the start address, this fixes raycris song #9 taito_zm.cpp: Adjust volume balance, hopefully fixing psyvarrv. I would need hardware recording for proper verification though tms57002: forgot MACC pipelining for some instructions
cuavas
pushed a commit
that referenced
this pull request
Sep 20, 2018
After another two "tehkanwch" boards were found and dumped (where this ROM matched the parent), and a deeper analisys from Roberto Fresca (who thinks that it was a bitrot, since it was a nonsense modification of a sprite), I've changed the ROM #9 (gfx1) to match the parent, as found on the new dumps.
couriersud
referenced
this pull request
Apr 17, 2019
Adjust warning levels and fix a number of topics identified.
Closed
angelosa
added a commit
that referenced
this pull request
Jun 10, 2023
------------------------------- a800.xml: Atrax #1, Atrax #2, Atrax #3, Atrax #4, Atrax #5, Atrax #6, Atrax #8, Atrax #9, Atrax #10, Atrax #11, Atrax #12, Atrax #13, Atrax #15 [Atarimania] a800.xml: Prince of Persia (AtariMAX i/f), Prince of Persia (SIC! i/f) [AtariAge] New software list items marked not working ------------------------------------------ a800.xml: Atrax #14, Atrax #16 [Atarimania]
lkundrak
added a commit
to lkundrak/mame-altos586
that referenced
this pull request
Oct 29, 2023
Otherwise imgtool gets unhappy with IMD images: Starting program: ./imgtool identify ./altos586/SDX-586.IMD ... Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 mamedev#2 0x000000000024807d in imgtool_floppy_open_internal (stream=..., image=...) at .../src/tools/imgtool/iflopimg.cpp:83 mamedev#3 imgtool_floppy_open (image=..., stream=...) at .../src/tools/imgtool/iflopimg.cpp:101 mamedev#4 0x000000000024bbdf in imgtool::image::internal_open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, createopts=createopts@entry=0x0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:986 mamedev#5 0x000000000024bd19 in imgtool::image::open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:1010 mamedev#6 0x0000000000250413 in evaluate_module (fname=fname@entry=0x2fa610 "./altos586/SDX-586.IMD", module=0x302320, result=@0x7fffffffd4dc: 0) at .../src/tools/imgtool/imgtool.cpp:271 mamedev#7 0x000000000025075f in imgtool::image::identify_file (fname=0x2fa610 "./altos586/SDX-586.IMD", modules=modules@entry=0x7fffffffd5d0, count=127, count@entry=128) at/usr/include/c++/13/bits/unique_ptr.h:199 mamedev#8 0x000000000025382e in cmd_identify (c=0x229d50 <cmds+400>, argc=<optimized out>, argv=0x7fffffffda00) at .../src/tools/imgtool/main.cpp:578 mamedev#9 0x0000000000253efc in main (argc=3, argv=0x7fffffffd9f0) at .../src/tools/imgtool/main.cpp:939 (gdb) up mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 520 int sectors_per_track = callbacks->get_sectors_per_track(floppy, 0, 20); (gdb) print *callbacks $2 = {read_sector = 0x28de1c <imd_read_sector(...)>, write_sector = 0x0, read_indexed_sector = 0x28de03 <imd_read_indexed_sector(...)>, write_indexed_sector = 0x28de35 <imd_write_indexed_sector(...)>, read_track = 0x0, write_track = 0x0, format_track = 0x0, post_format = 0x0, get_heads_per_disk = 0x28dfef <imd_get_heads_per_disk(...)>, get_tracks_per_disk = 0x28dfff <imd_get_tracks_per_disk(...)>, get_sectors_per_track = 0x0, get_track_size = 0x0, get_sector_length = 0x28dd1c <imd_get_sector_length(...)>, get_indexed_sector_info = 0x28d95c <imd_get_indexed_sector_info(...)>, get_track_data_offset = 0x0} (gdb) With patch applied: $ ./imgtool identify ./altos586/SDX-586.IMD imd_vzdos IMD floppy disk image (VZ-DOS format) imd_dgndos IMD floppy disk image (Dragon DOS format)
lkundrak
added a commit
to lkundrak/mame-altos586
that referenced
this pull request
Oct 29, 2023
Otherwise imgtool gets unhappy with IMD images: Starting program: ./imgtool identify ./altos586/SDX-586.IMD ... Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 mamedev#2 0x000000000024807d in imgtool_floppy_open_internal (stream=..., image=...) at .../src/tools/imgtool/iflopimg.cpp:83 mamedev#3 imgtool_floppy_open (image=..., stream=...) at .../src/tools/imgtool/iflopimg.cpp:101 mamedev#4 0x000000000024bbdf in imgtool::image::internal_open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, createopts=createopts@entry=0x0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:986 mamedev#5 0x000000000024bd19 in imgtool::image::open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:1010 mamedev#6 0x0000000000250413 in evaluate_module (fname=fname@entry=0x2fa610 "./altos586/SDX-586.IMD", module=0x302320, result=@0x7fffffffd4dc: 0) at .../src/tools/imgtool/imgtool.cpp:271 mamedev#7 0x000000000025075f in imgtool::image::identify_file (fname=0x2fa610 "./altos586/SDX-586.IMD", modules=modules@entry=0x7fffffffd5d0, count=127, count@entry=128) at/usr/include/c++/13/bits/unique_ptr.h:199 mamedev#8 0x000000000025382e in cmd_identify (c=0x229d50 <cmds+400>, argc=<optimized out>, argv=0x7fffffffda00) at .../src/tools/imgtool/main.cpp:578 mamedev#9 0x0000000000253efc in main (argc=3, argv=0x7fffffffd9f0) at .../src/tools/imgtool/main.cpp:939 (gdb) up mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 520 int sectors_per_track = callbacks->get_sectors_per_track(floppy, 0, 20); (gdb) print *callbacks $2 = {read_sector = 0x28de1c <imd_read_sector(...)>, write_sector = 0x0, read_indexed_sector = 0x28de03 <imd_read_indexed_sector(...)>, write_indexed_sector = 0x28de35 <imd_write_indexed_sector(...)>, read_track = 0x0, write_track = 0x0, format_track = 0x0, post_format = 0x0, get_heads_per_disk = 0x28dfef <imd_get_heads_per_disk(...)>, get_tracks_per_disk = 0x28dfff <imd_get_tracks_per_disk(...)>, get_sectors_per_track = 0x0, get_track_size = 0x0, get_sector_length = 0x28dd1c <imd_get_sector_length(...)>, get_indexed_sector_info = 0x28d95c <imd_get_indexed_sector_info(...)>, get_track_data_offset = 0x0} (gdb) With patch applied: $ ./imgtool identify ./altos586/SDX-586.IMD imd_vzdos IMD floppy disk image (VZ-DOS format) imd_dgndos IMD floppy disk image (Dragon DOS format)
lkundrak
added a commit
to lkundrak/mame-altos586
that referenced
this pull request
Oct 29, 2023
…er_track() The crash: Starting program: ./imgtool identify ./altos586/SDX-586.IMD ... Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 mamedev#2 0x000000000024807d in imgtool_floppy_open_internal (stream=..., image=...) at .../src/tools/imgtool/iflopimg.cpp:83 mamedev#3 imgtool_floppy_open (image=..., stream=...) at .../src/tools/imgtool/iflopimg.cpp:101 mamedev#4 0x000000000024bbdf in imgtool::image::internal_open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, createopts=createopts@entry=0x0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:986 mamedev#5 0x000000000024bd19 in imgtool::image::open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:1010 mamedev#6 0x0000000000250413 in evaluate_module (fname=fname@entry=0x2fa610 "./altos586/SDX-586.IMD", module=0x302320, result=@0x7fffffffd4dc: 0) at .../src/tools/imgtool/imgtool.cpp:271 mamedev#7 0x000000000025075f in imgtool::image::identify_file (fname=0x2fa610 "./altos586/SDX-586.IMD", modules=modules@entry=0x7fffffffd5d0, count=127, count@entry=128) at/usr/include/c++/13/bits/unique_ptr.h:199 mamedev#8 0x000000000025382e in cmd_identify (c=0x229d50 <cmds+400>, argc=<optimized out>, argv=0x7fffffffda00) at .../src/tools/imgtool/main.cpp:578 mamedev#9 0x0000000000253efc in main (argc=3, argv=0x7fffffffd9f0) at .../src/tools/imgtool/main.cpp:939 (gdb) up mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 520 int sectors_per_track = callbacks->get_sectors_per_track(floppy, 0, 20); (gdb) print *callbacks $2 = {read_sector = 0x28de1c <imd_read_sector(...)>, write_sector = 0x0, read_indexed_sector = 0x28de03 <imd_read_indexed_sector(...)>, write_indexed_sector = 0x28de35 <imd_write_indexed_sector(...)>, read_track = 0x0, write_track = 0x0, format_track = 0x0, post_format = 0x0, get_heads_per_disk = 0x28dfef <imd_get_heads_per_disk(...)>, get_tracks_per_disk = 0x28dfff <imd_get_tracks_per_disk(...)>, get_sectors_per_track = 0x0, get_track_size = 0x0, get_sector_length = 0x28dd1c <imd_get_sector_length(...)>, get_indexed_sector_info = 0x28d95c <imd_get_indexed_sector_info(...)>, get_track_data_offset = 0x0} (gdb) With patch applied: $ ./imgtool identify ./altos586/SDX-586.IMD imd_vzdos IMD floppy disk image (VZ-DOS format) imd_dgndos IMD floppy disk image (Dragon DOS format)
lkundrak
added a commit
to lkundrak/mame-altos586
that referenced
this pull request
Oct 29, 2023
…er_track() The crash: Starting program: ./imgtool identify ./altos586/SDX-586.IMD ... Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 mamedev#2 0x000000000024807d in imgtool_floppy_open_internal (stream=..., image=...) at .../src/tools/imgtool/iflopimg.cpp:83 mamedev#3 imgtool_floppy_open (image=..., stream=...) at .../src/tools/imgtool/iflopimg.cpp:101 mamedev#4 0x000000000024bbdf in imgtool::image::internal_open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, createopts=createopts@entry=0x0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:986 mamedev#5 0x000000000024bd19 in imgtool::image::open (module=module@entry=0x302320, filename="./altos586/SDX-586.IMD", read_or_write=read_or_write@entry=0, outimg=std::unique_ptr<imgtool::image> = {...}) at .../src/tools/imgtool/imgtool.cpp:1010 mamedev#6 0x0000000000250413 in evaluate_module (fname=fname@entry=0x2fa610 "./altos586/SDX-586.IMD", module=0x302320, result=@0x7fffffffd4dc: 0) at .../src/tools/imgtool/imgtool.cpp:271 mamedev#7 0x000000000025075f in imgtool::image::identify_file (fname=0x2fa610 "./altos586/SDX-586.IMD", modules=modules@entry=0x7fffffffd5d0, count=127, count@entry=128) at/usr/include/c++/13/bits/unique_ptr.h:199 mamedev#8 0x000000000025382e in cmd_identify (c=0x229d50 <cmds+400>, argc=<optimized out>, argv=0x7fffffffda00) at .../src/tools/imgtool/main.cpp:578 mamedev#9 0x0000000000253efc in main (argc=3, argv=0x7fffffffd9f0) at .../src/tools/imgtool/main.cpp:939 (gdb) up mamedev#1 0x000000000025d426 in bml3_diskimage_open (image=..., dummy=...) at .../src/tools/imgtool/modules/bml3.cpp:520 520 int sectors_per_track = callbacks->get_sectors_per_track(floppy, 0, 20); (gdb) print *callbacks $2 = {read_sector = 0x28de1c <imd_read_sector(...)>, write_sector = 0x0, read_indexed_sector = 0x28de03 <imd_read_indexed_sector(...)>, write_indexed_sector = 0x28de35 <imd_write_indexed_sector(...)>, read_track = 0x0, write_track = 0x0, format_track = 0x0, post_format = 0x0, get_heads_per_disk = 0x28dfef <imd_get_heads_per_disk(...)>, get_tracks_per_disk = 0x28dfff <imd_get_tracks_per_disk(...)>, get_sectors_per_track = 0x0, get_track_size = 0x0, get_sector_length = 0x28dd1c <imd_get_sector_length(...)>, get_indexed_sector_info = 0x28d95c <imd_get_indexed_sector_info(...)>, get_track_data_offset = 0x0} (gdb) With patch applied: $ ./imgtool identify ./altos586/SDX-586.IMD imd_vzdos IMD floppy disk image (VZ-DOS format) imd_dgndos IMD floppy disk image (Dragon DOS format)
mizapf
referenced
this pull request
May 1, 2024
* Feed mouse/pen/touch pointer events through UI input manager with Win32 and SDL. * Started migrating UI code to use new API and reworking mouse/touch interaction. * emu/render.cpp: Support pressing multiple clickable layout items simultaneously. * emu/render.cpp: Allow UI elements to be drawn in any window. * emu/rendlay.cpp, luaengine_render.cpp: Added layout view events for pointer input. * ui/ui.cpp: Allow the UI handler to control pointer display. * ui/analogipt.cpp: Added mouse/touch and more keys for navigating field state list. * ui/menu.cpp: Use vertical swipe to scroll and horizontal swipe to adjust. * ui/menu.cpp: Draw after processing input - greatly improves responsiveness. * ui/menu.cpp: Ignore keyboard/gamepad input during pointer actions. * ui/selmenu.cpp: Made left/right info pane arrows repeat when held. * ui/selmenu.cpp: Use middle click to move keyboard focus. * ui/selmenu.cpp: Let filter list scroll if it's too tall, and use a bit of horizontal padding. * ui/selmenu.cpp: Improved divider sizing. * ui/state.cpp: Don't allow clicks to pass through the confirm deletion prompt to the menu. * ui/simpleselgame.cpp: Fixed error message display and graphics/sound status not showing. * ui/simpleselgame.cpp: Allow tap/click to dismiss error message. * ui/utils.cpp: Show UI for choice filters when there are no choices - it's less confusing. * modules/input/input_sdl.cpp: Made scaling for mouse scroll better match RawInput and DirectInput. * modules/input/input_rawinput.cpp: Added support for horizontal scroll axis. * modules/input/input_win32.cpp: Added support for scroll axes and more buttons to mouse/lightgun. * modules/debugger/debugimgui.cpp: Don't fight over events with the UI manager - it breaks menus. * osd/windows/window.cpp: Translate mouse position to window cooridinates for scroll wheel events. * osd/sdl/window.cpp: Supply last mouse position for scroll wheel events if possible. * scripts/build/complay.py: Made zero input mask an error - it was only being used to block clicks.
cuavas
pushed a commit
that referenced
this pull request
Jul 25, 2024
…2582) * Improved some NV Magazine titles. * Removed Removed "R・SYSTEM 3.2 (Japan)", (part of NV Magazine 1996-12). New working software list items (msx2_flop.xml) ---------------------------- NV Hokkaido Vol. 1 (Japan) [file-hunter] NV Magazine 1 (Japan) [file-hunter] NV Magazine 2 (Japan) [file-hunter] NV Magazine #3 (Japan) [file-hunter] NV Magazine 4 (Japan) [file-hunter] NV Magazine #5 (Japan) [file-hunter] NV Magazine #7 (Japan) [file-hunter] NV Magazine #8 (Japan) [file-hunter] NV Magazine #9 (Japan) [file-hunter] NV Magazine #10 (Japan) [file-hunter] NV Magazine #20 (Japan) [file-hunter] NV Magazine #21 (Japan) [file-hunter] NV Magazine #22 (Japan) [file-hunter] NV Magazine #23 (Japan) [file-hunter] NV Magazine #24 (Japan) [file-hunter] NV Magazine #26 (Japan) [file-hunter] NV Magazine 1996-10 (Japan) [file-hunter] NV Magazine 1996-11 (Japan) [file-hunter] NV Magazine 1998-6 (Japan) [file-hunter] NV Magazine 1998-9 (Japan) [file-hunter] NV Magazine 1998-10 (Japan) [file-hunter] NV Magazine 1999-1 (Japan) [file-hunter] NV Magazine 1999-2 (Japan) [file-hunter] NV Magazine 1999-3 (Japan) [file-hunter] NV Magazine 1999-5 (Japan) [file-hunter] NV Magazine 1999-6 (Japan) [file-hunter] NV Magazine 1999-7 (Japan) [file-hunter] NV Magazine 1999-8 (Japan) [file-hunter] NV Magazine 1999-9 (Japan) [file-hunter] NV Magazine 1999-10 (Japan) [file-hunter] NV Magazine 1999-11 (Japan) [file-hunter] NV Magazine 2000-1 (Japan) [file-hunter] NV Magazine 2000-2 (Japan) [file-hunter] NV Magazine 2000-3 (Japan) [file-hunter] NV Magazine 2000-4 (Japan) [file-hunter] NV Magazine 2000-5 (Japan) [file-hunter] NV Magazine 2000-6 (Japan) [file-hunter] NV Magazine 2000-7 (Japan) [file-hunter] NV Magazine 2000-8 (Japan) [file-hunter] NV Magazine 2000-9 (Japan) [file-hunter] NV Magazine 2000-10 (Japan) [file-hunter] NV Magazine 2000-11 (Japan) [file-hunter] NV Magazine 2000-12 (Japan) [file-hunter] NV Magazine 2002-1 (Japan) [file-hunter] NV Magazine 2002-2 (Japan) [file-hunter] NV Magazine 2002-4 (Japan) [file-hunter] NV Magazine 2002-5 (Japan) [file-hunter] NV Magazine SP #2 (Japan) [file-hunter] NV Magazine Special #3 (Japan) [file-hunter] NV Magazine Special #4 (Japan) [file-hunter] NV Magazine Special #6 (Japan) [file-hunter] NV RSDM #4 (Japan) [file-hunter] New software list items marked not working (msx2_flop.xml) ---------------------------- NV Magazine 1996-12 (Japan) [file-hunter] NV Magazine 1998-11 (Japan) [file-hunter] NV Magazine 2001-12 (Japan) [file-hunter] NV Magazine 2002-3 (Japan) [file-hunter]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BEXT instruction is needed for the Unisonic Champion driver which I'm building.
The Intellivision doesn't need it since its EBCA0, EBCA1,EBCA2 and EBCA3 pins are grounded.
The method used was a suggestion from RB