spec128.cpp, specpls3.cpp: Added initial bus contention emulation for Spectrum 128+ models #9640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please be a bit more descriptive in pull request titles and commit messages. It’s far better when dealing with the history if the main thing affected is more immediately apparent. “128+ models” doesn’t make sense without context, and “initial contention” on its own doesn’t really describe what this does. |
cuavas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes ula128 test work for spectrum 128, +2 models
+2A, +3 uses same pattern as models above but possibly this test not expected to work on there models - nice to have confirmation from owners of physical devices.
compare to master:
