rc2014 code review fixes #9768
Merged
rc2014 code review fixes #9768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
May 16, 2022
Comment on lines
+60
to
+64
| void rc2014_bus_device::device_reset() | ||
| { | ||
| installer(AS_IO)->unmap_readwrite(0, (1 << installer(AS_IO)->space_config().addr_width()) - 1); | ||
| } | ||
|
|
There was a problem hiding this comment.
This requires the bus to come before the slots in machine configuration to work, as the cards are expecting their device_reset members to run after this. If it becomes a problem, it can be changed to have a specific function on the cards to install I/O handlers.
wilbertpol
pushed a commit
to wilbertpol/mame
that referenced
this pull request
May 17, 2022
* Unmap I/O space on bus reset and install I/O on card reset. * Cleaned up code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses all the issues mentioned in #9759