Skip to content

v4.68.1

Choose a tag to compare

View all tags
@github-actions github-actions released this 27 Oct 17:07
· 1019 commits to main since this release
v4.68.1
1c419c8

Patch, cut from 4.68.0. A correct cross-AI verdict no longer fails in CI because of the reviewer's gitconfig, and Solomon never advises dropping the target of a symlink.

Fixed

  • The diffs kj hashes and parses no longer depend on the user's gitconfig (KJC-BUG-0408 and KJC-BUG-0415, issues #2560 and #2622): kj pins, for every git it runs, the diff headers (a/ and b/) and every option that changes the diff text (diff.algorithm, context, renames, indent heuristic, color) to git's defaults. With diff.algorithm=histogram in a reviewer's gitconfig, kj review --staged recorded a hash that kj review --verify-pr never recomputed in CI. Machines with default config hash exactly as before.
  • Solomon never takes a symlink's target out of the commit (KJC-BUG-0414, issues #2606 and #2564): kj gives Solomon the change's symlinks and their targets, and drops any condition that would unstage, remove or restore a target, saying so. Following such advice committed the link dangling.
Assets 8
Loading