This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Fix possibly race on undefined behavior #12408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`runnable->iter = runnables.end()` assumes that `::end()` is a `static` or `constxpr` and thread-safe. This is likely to be true for most of the implementations. That said we cannot rely on undefined behavior and we should assume the worse case scenario.
kkaefer
approved these changes
Jul 17, 2018
There was a problem hiding this comment.
Your hunch that actual implementation in the GNU STL in https://github.com/gcc-mirror/gcc/blob/ca434dcf2fcfaadd3eb304a991d0612ecc4e6a12/libstdc%2B%2B-v3/include/bits/stl_list.h#L964-L971 and in libc++ at https://github.com/llvm-mirror/libcxx/blob/ffbb91bb640b1b0425a91aa70e2a6a2e0f7244e0/include/list#L624-L632 don't mutate any state seems correct.
ChrisLoer
approved these changes
Jul 17, 2018
jfirebaugh
approved these changes
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runnable->iter = runnables.end()assumes that::end()is astaticorconstxprand thread-safe. This is likely to be true for most of the implementations. That said we cannot rely on undefined behavior and we should assume the worse case scenario.