This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Replace hardcode telemetry settings string by resources variant #12707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-translatable-telemetry-settings
branch
from
7b2170f
to
0628971
Compare
LukasPaczos
reviewed
Aug 22, 2018
| public AttributionParser build() { | ||
| if (attributionDataStringArray == null) { | ||
| throw new IllegalStateException("Using builder without providing attribution data"); | ||
| } | ||
|
|
||
| if (context == null) { | ||
| throw new IllegalStateException("Using builder without providing a context"); |
There was a problem hiding this comment.
Isn't this a semver-major change?
There was a problem hiding this comment.
yes, you are right, I can revisit this PR so it returns the hardcoded string in case of no context provided.
There was a problem hiding this comment.
Made this change backwards compatible, see https://github.com/mapbox/mapbox-gl-native/pull/12707/files#diff-4d31b0b92dcd5125ea5d5a966d049f7aR176 where we check for availability for context, if not available use old hardcoded string instead.
tobrun
force-pushed
the
tvn-translatable-telemetry-settings
branch
from
0628971
to
e5d3645
Compare
LukasPaczos
approved these changes
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #12696 (comment)