This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Avoid clustering unclusterable GeoJSON #7633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
clustering
Core
|
@1ec5, thanks for your PR! By analyzing this pull request, we identified @mourner, @jfirebaugh and @boundsj to be potential reviewers. |
mourner
approved these changes
Jan 8, 2017
I optimistically included a unit test that depends on #7632. Once that PR lands and I rebase this branch, the test will pass with flying colors. 🌈 |
|
#7632 is ready! |
Ignore empty feature collections or non–feature collections for the purposes of clustering or tiling. A source’s clustering option can only be set when the source is constructed, but setGeoJSON() enables the developer to swap a clusterable feature for an unclusterable geometry and back.
1ec5
force-pushed
the
1ec5-cluster-empty-7622
branch
from
3e402a8
to
c6e60b8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore empty feature collections or non–feature collections for the purposes of deciding whether to cluster or tile the GeoJSON. A source’s clustering option can only be set when the source is constructed, but
setGeoJSON()enables the developer to swap a clusterable feature for an unclusterable geometry and back.Added iOS/macOS unit tests of creating shape sources with unclusterable shapes. The second of these tests depends on #7632 to pass.
Fixes #7622.
/cc @boundsj