This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Cherry-pick #9817: Remove database on schema downgrade #9837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
force-pushed
the
fb-9817-cherry-pick
branch
from
cad76f3
to
5415df9
Compare
|
Modified the |
|
@tmpsantos Please review when you get a chance. 🙇 @fabian-guerra @1ec5 I’m on the fence about changelogging this one — thoughts? |
|
This currently only has an effect on caches created from a build on master, but not from any previous release or prerelease, correct? If that’s the case, then I’d lean against release-noting it. |
friedbunny
force-pushed
the
fb-9817-cherry-pick
branch
from
5415df9
to
5ef5df3
Compare
tmpsantos
approved these changes
Aug 29, 2017
Previously we were throwing an exception.
Which is, delete and recreate the database.
Originally part of the much larger f0a7c45
friedbunny
force-pushed
the
fb-9817-cherry-pick
branch
from
5ef5df3
to
eedd909
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in #9817 to fix #9776. Databases with an unknown schema (e.g., v6 from master) will now be deleted and a new database initialized.
/cc @tobrun @jfirebaugh @tmpsantos