Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react leaflet to v4 and bump various other related dependencies #2367

Merged
merged 49 commits into from
Jul 9, 2024

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Jun 20, 2024

Bump leaflet from v1.6.0 to v1.9.4
Bump leaflet-lasso from v2.1.0 to v2.2.13
Adapt leaflet-vectoricon to work with upgraded leaflet versions.
Bump leaflet.markercluster from v1.4.1 to v1.5.3
Add @react-leaflet/core v2.1.0 to replace broken leafelt control components
Bump react-leaflet from v2.7.0 to v4.2.1
Bump react-leaflet-bing-v2 from v5.1.2 to v5.2.3
Bump react-leaflet-markercluster from v2.0.0 to v4.0.0-rc1
@testing-library/jest-dom from v6.1.4 to v6.4.6
Added --transformIgnorePatterns "node_modules/(?!react-leaflet)/" to test scripts to fix compatibility issues between jest and react-leaflet dependencies.

Other enhancements in this PR:

  • Fixes for some of the warnings and errors in jest tests.
  • Better handling of recentering and initial map bounds for bundled tasks.
  • Reduction of amount of re-renders when re-rendering map markers.
  • Persistence of spidered tasks when dragging map.
  • Persistence of marker popups between re-renders.
  • Simplify use of un-clustering tasks.
  • Remove overlapping tasks marker to allow users to un-cluster overlapped tasks, spider them, and open their individual popups. (Before users could not split these tasks)
  • Improve resizability of the work on multiple tasks together widget map.

@CollinBeczak CollinBeczak changed the title Bump react leaflet to v4 Bump react leaflet to v4 and bump various other related dependencies Jun 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 24.30939% with 411 lines in your changes missing coverage. Please review.

Project coverage is 23.48%. Comparing base (734d320) to head (9a2b7e7).

Files Patch % Lines
src/components/TaskClusterMap/MapMarkers.js 30.48% 98 Missing and 32 partials ⚠️
src/components/TaskPane/TaskMap/TaskMap.js 2.41% 100 Missing and 21 partials ⚠️
src/components/TaskClusterMap/TaskClusterMap.js 43.92% 50 Missing and 10 partials ⚠️
...omponents/EnhancedMap/OSMDataLayer/OSMDataLayer.js 6.38% 42 Missing and 2 partials ⚠️
...s/EnhancedMap/TaskFeatureLayer/TaskFeatureLayer.js 0.00% 12 Missing and 4 partials ⚠️
src/components/SupplementalMap/SupplementalMap.js 16.66% 8 Missing and 2 partials ⚠️
...omponents/TaskPane/TaskNearbyList/TaskNearbyMap.js 0.00% 5 Missing and 2 partials ⚠️
...s/EnhancedMap/FitBoundsControl/FitBoundsControl.js 16.66% 3 Missing and 2 partials ⚠️
...s/EnhancedMap/SourcedTileLayer/SourcedTileLayer.js 68.75% 4 Missing and 1 partial ⚠️
...ponents/EnhancedMap/SearchControl/SearchControl.js 33.33% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
+ Coverage   23.36%   23.48%   +0.11%     
==========================================
  Files         649      649              
  Lines       22750    22500     -250     
  Branches     7054     6938     -116     
==========================================
- Hits         5316     5284      -32     
+ Misses      14563    14403     -160     
+ Partials     2871     2813      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvexel
Copy link
Member

mvexel commented Jun 25, 2024

Looking at this...
On the Find Challenges, main Challenge screen, and Task maps, I can no longer use the trackpad to zoom in / out (two finger drag) or pan the map using the trackpad. Panning with keyboard (arrow keys) and zooming in / out using the map UI elements (+/- buttons).
This is on Mac Firefox 126.0.1

@CollinBeczak
Copy link
Collaborator Author

Looking at this... On the Find Challenges, main Challenge screen, and Task maps, I can no longer use the trackpad to zoom in / out (two finger drag) or pan the map using the trackpad. Panning with keyboard (arrow keys) and zooming in / out using the map UI elements (+/- buttons). This is on Mac Firefox 126.0.1

Thank for letting me know about this! It should be fixed now.

@CollinBeczak CollinBeczak marked this pull request as ready for review June 30, 2024 21:06
@CollinBeczak CollinBeczak marked this pull request as draft July 4, 2024 18:17
@CollinBeczak CollinBeczak marked this pull request as ready for review July 4, 2024 21:42
@CollinBeczak CollinBeczak mentioned this pull request Jul 5, 2024
@CollinBeczak CollinBeczak merged commit 1f6a1c4 into main Jul 9, 2024
6 checks passed
@CollinBeczak CollinBeczak deleted the bump-react-leaflet-to-v4 branch July 9, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants