Skip to content

Commit 74ceab5

Browse files
committed
[misc] force test TLSv1.1 compatibility if Node.js 12 and MySQL before version 8.0
1 parent a9e11b1 commit 74ceab5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/integration/test-ssl.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ describe('ssl', function() {
1313
before(function(done) {
1414
if (process.env.MAXSCALE_VERSION) this.skip();
1515
if (
16-
process.platform === 'win32' &&
1716
tls.DEFAULT_MIN_VERSION === 'TLSv1.2' &&
18-
((shareConn.info.isMariaDB() && !shareConn.info.hasMinVersion(10, 4, 0)) ||
17+
((process.platform === 'win32' && shareConn.info.isMariaDB() && !shareConn.info.hasMinVersion(10, 4, 0)) ||
1918
(!shareConn.info.isMariaDB() && !shareConn.info.hasMinVersion(8, 0, 0)))
2019
) {
21-
//TLSv1.2 is supported on windows only since MariaDB 10.4 and MySQL 8.0
20+
//TLSv1.2 is supported on windows only since MariaDB 10.4
21+
//TLSv1.2 is supported in MySQL only since 8.0 (unix/windows)
2222
//so if testing with Node.js 12, force possible TLS1.1
2323
tls.DEFAULT_MIN_VERSION = 'TLSv1.1';
2424
}

0 commit comments

Comments
 (0)