Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kiosk consumers #1639

Merged
merged 13 commits into from
Jun 20, 2024
Merged

feat: kiosk consumers #1639

merged 13 commits into from
Jun 20, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Jun 18, 2024

A "kiosk" consumer has a "kiosk view" when running marimo. This is some middleground before going full multi-player. It allows you to see and the outputs and interactive with the widgets, but not right any code.

This view is the editor view without the ability to actually edit any code or run cells, but you get the sidebar and other useful editor features.

A kiosk consumer doesn't have less permission than an editor from the API layer, just that we hide potentially conflicting operations. (that we do not keep in sync).

Over time, we will move more state to the backend and we can loosen what is shown, however, the use-case for this right now is for vscode/vim to be able to write code in vscode/vim but see rich outputs in marimo.

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 6:36pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 6:36pm

@@ -114,7 +114,7 @@ class CreationRequest:


@dataclass
class DeleteRequest:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha thanks

@@ -264,6 +272,58 @@ def kernel_connection(self) -> TypedConnection[KernelMessage]:
return self._read_conn


class Room:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@akshayka akshayka merged commit 3c1ec80 into main Jun 20, 2024
30 checks passed
@akshayka akshayka deleted the ms/kiosk branch June 20, 2024 22:19
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.6.22-dev2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants